Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AbortController and AbortSignal #9361

Merged
merged 1 commit into from Feb 5, 2018

Commits on Feb 5, 2018

  1. Implement AbortController and AbortSignal

    Also adjust layout tests expectations to match the new behaviour. One
    fetch() wpt test that previously failed due to AbortController being
    undefined now times out because the "signal" properties in fetch options
    doesn't do anything yet. This will be fixed once it is implemented.
    
    Spec: https://dom.spec.whatwg.org/#aborting-ongoing-activities
    Design doc: https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit
    Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9vNZh4fhV2U/ZVxD2iQACgAJ
    
    BUG=750599
    
    Change-Id: I0e504bbf7f8552d602913ee2069bbf90f95deaff
    Reviewed-on: https://chromium-review.googlesource.com/896669
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#534352}
    ricea authored and chromium-wpt-export-bot committed Feb 5, 2018
    Copy the full SHA
    6fd9710 View commit details
    Browse the repository at this point in the history