Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move String16 mojom to mojo/public/cpp/base #9369

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 2, 2018

Also, for filenames related to String16, struct_traits => mojom_traits
and CommonCustomTypesStructTraits => String16MojomTraits

TBR=sky@chromium.org

Bug: 806965,799482
Change-Id: I4f725df6a90bc1d5ec75988bff281bf87832714b
Reviewed-on: https://chromium-review.googlesource.com/900060
Commit-Queue: Ken Rockot rockot@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Cr-Commit-Position: refs/heads/master@{#534282}


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 2, 2018

Build PASSED

Started: 2018-02-03 20:38:40
Finished: 2018-02-03 20:43:30

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-900060 branch 5 times, most recently from 5f35c54 to ca0f584 Feb 3, 2018

Move String16 mojom to mojo/public/cpp/base
Also, for filenames related to String16, struct_traits => mojom_traits
and CommonCustomTypesStructTraits => String16MojomTraits

TBR=sky@chromium.org

Bug: 806965,799482
Change-Id: I4f725df6a90bc1d5ec75988bff281bf87832714b
Reviewed-on: https://chromium-review.googlesource.com/900060
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534282}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-900060 branch from ca0f584 to e76300f Feb 3, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7d9600c into master Feb 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-900060 branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.