Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ::slotted in ComputeLinkMatchType. #9413

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 6, 2018

We skipped the selector list for ::slotted looking for :visited and
:link pseudo classes and ended up applying such rules with both :visited
and :link style.

Bug: 808392
Change-Id: I85956902f3ca9cea01c96ef5c56ccf7f0ee23671
Reviewed-on: https://chromium-review.googlesource.com/904903
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#536328}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 6, 2018

Build PASSED

Started: 2018-02-13 10:57:21
Finished: 2018-02-13 11:01:45

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-904903 branch from 13fa280 to 8fa39d2 Feb 12, 2018

Handle ::slotted in ComputeLinkMatchType.
We skipped the selector list for ::slotted looking for :visited and
:link pseudo classes and ended up applying such rules with both :visited
and :link style.

Bug: 808392
Change-Id: I85956902f3ca9cea01c96ef5c56ccf7f0ee23671
Reviewed-on: https://chromium-review.googlesource.com/904903
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536328}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-904903 branch from 8fa39d2 to 8fc0eda Feb 13, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c6b11a5 into master Feb 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-904903 branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.