[Gecko Bug 1436659] Rename tests in timing-model/animations to match spec section titles; #9522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this folder we have a mixture of tests named after the procedure they are testing or the section that contains the procedure. The latter seems to be more common and makes it a little easier to check that all sections are tested so this patch renames files to refer to the section titles instead. It also updates a few of the test file titles and URLs. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: a9777027b7ad5daed663df32ce3fcc9cb6502b9d gecko-integration-branch: autoland gecko-reviewers: hiro
Using async/await makes these tests easier to read and appears to be supported in all browsers now. This patch updates the tests in web-animations/timing-model/animations since we will update these tests later in this patch series and it will be easier if we convert them to using async first. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: c2932cd4839fd8d93b73860bf50b20b8499a4986 gecko-integration-branch: autoland gecko-reviewers: hiro
The test under web-animations/interfaces/Animation/playbackRate.html is really testing the timing model so this patch moves it there. We'll simplify it in the next patch. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: 071666b6c7e9c6de8a6ec20ba138ee18fd1972e3 gecko-integration-branch: autoland gecko-reviewers: hiro
I didn't like the way these tests were written so I decided to rewrite them to make it more clear what they are trying to test. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: 737ff1676ff0776b213b71a5d44784bd3dcd1aa7 gecko-integration-branch: autoland gecko-reviewers: hiro
These tests are not testing the interface so much as the 'finish an animation' procedure. This patch simply moves the tests as-is. They will be simplified in the next patch in this series. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: 467dd218d3d32373191863a79e5d6716b45ad043 gecko-integration-branch: autoland gecko-reviewers: hiro
These patches update these tests as follows: * Used async/await where it simplifies the tests * Updated the test descriptions to reflect what they are testing in the timing model * Fixed a couple of bugs where we set the playbackRate on a pause-pending animation (which causes it to no longer be pause-pending). In the process I noticed a couple of tests that don't really belong here. They will be moved in the next patch. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: bfa0d1a4bf1cc49f63ad1aee3c4ab5edc5a0f529 gecko-integration-branch: autoland gecko-reviewers: hiro
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: 920aa51ae3a22c858daaad63b54d520259b856d2 gecko-integration-branch: autoland gecko-reviewers: hiro
These tests test the behavior introduced in the following changesets to the Web Animations specification: 1. w3c/csswg-drafts@5af5e27 2. w3c/csswg-drafts@673f6fc which can be viewed as a merged diff at: https://gist.github.com/birtles/d147eb2e0e2d4d37fadf217abd709411 See the following spec issues: 1. w3c/csswg-drafts#2059 2. w3c/csswg-drafts#2266 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659 gecko-commit: 8f61bf3de90affb12962bd6556a6ee5530c15c5f gecko-integration-branch: autoland gecko-reviewers: hiro
wpt-pr-bot
approved these changes
Feb 14, 2018
Build ERROREDStarted: 2018-02-14 20:20:21 Failing Jobs
Unstable ResultsBrowser: "Firefox Nightly"View in: WPT PR Status | TravisCI
|
|
That's not a new test and shouldn't block this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this folder we have a mixture of tests named after the procedure they are
testing or the section that contains the procedure. The latter seems to be more
common and makes it a little easier to check that all sections are tested so
this patch renames files to refer to the section titles instead. It also updates
a few of the test file titles and URLs.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: a9777027b7ad5daed663df32ce3fcc9cb6502b9d
gecko-integration-branch: autoland
gecko-reviewers: hiro