Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1436659] Rename tests in timing-model/animations to match spec section titles; #9522

Closed
wants to merge 8 commits into from

Conversation

Projects
None yet
4 participants
@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Feb 14, 2018

In this folder we have a mixture of tests named after the procedure they are
testing or the section that contains the procedure. The latter seems to be more
common and makes it a little easier to check that all sections are tested so
this patch renames files to refer to the section titles instead. It also updates
a few of the test file titles and URLs.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: a9777027b7ad5daed663df32ce3fcc9cb6502b9d
gecko-integration-branch: autoland
gecko-reviewers: hiro

birtles added some commits Feb 14, 2018

Rename tests in timing-model/animations to match spec section titles;
In this folder we have a mixture of tests named after the procedure they are
testing or the section that contains the procedure. The latter seems to be more
common and makes it a little easier to check that all sections are tested so
this patch renames files to refer to the section titles instead. It also updates
a few of the test file titles and URLs.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: a9777027b7ad5daed663df32ce3fcc9cb6502b9d
gecko-integration-branch: autoland
gecko-reviewers: hiro
Use async/await in timing-model/animations tests;
Using async/await makes these tests easier to read and appears to be supported
in all browsers now. This patch updates the tests in
web-animations/timing-model/animations since we will update these tests later in
this patch series and it will be easier if we convert them to using async first.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: c2932cd4839fd8d93b73860bf50b20b8499a4986
gecko-integration-branch: autoland
gecko-reviewers: hiro
Move playback rate test to timing-model;
The test under web-animations/interfaces/Animation/playbackRate.html is really
testing the timing model so this patch moves it there. We'll simplify it in the
next patch.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 071666b6c7e9c6de8a6ec20ba138ee18fd1972e3
gecko-integration-branch: autoland
gecko-reviewers: hiro
Simplify playback rate setting test;
I didn't like the way these tests were written so I decided to rewrite them to
make it more clear what they are trying to test.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 737ff1676ff0776b213b71a5d44784bd3dcd1aa7
gecko-integration-branch: autoland
gecko-reviewers: hiro
Move finishing tests to timing-model;
These tests are not testing the interface so much as the 'finish an animation'
procedure.

This patch simply moves the tests as-is. They will be simplified in the next
patch in this series.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 467dd218d3d32373191863a79e5d6716b45ad043
gecko-integration-branch: autoland
gecko-reviewers: hiro
Tidy up tests for "finishing an animation";
These patches update these tests as follows:

* Used async/await where it simplifies the tests
* Updated the test descriptions to reflect what they are testing in the timing
  model
* Fixed a couple of bugs where we set the playbackRate on a pause-pending
  animation (which causes it to no longer be pause-pending).

In the process I noticed a couple of tests that don't really belong here. They
will be moved in the next patch.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: bfa0d1a4bf1cc49f63ad1aee3c4ab5edc5a0f529
gecko-integration-branch: autoland
gecko-reviewers: hiro
Further divide up finishing tests;
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 920aa51ae3a22c858daaad63b54d520259b856d2
gecko-integration-branch: autoland
gecko-reviewers: hiro
Add tests for Animation.updatePlaybackRate;
These tests test the behavior introduced in the following changesets to the Web
Animations specification:

  1. w3c/csswg-drafts@5af5e27
  2. w3c/csswg-drafts@673f6fc

which can be viewed as a merged diff at:

  https://gist.github.com/birtles/d147eb2e0e2d4d37fadf217abd709411

See the following spec issues:

  1. w3c/csswg-drafts#2059
  2. w3c/csswg-drafts#2266
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436659
gecko-commit: 8f61bf3de90affb12962bd6556a6ee5530c15c5f
gecko-integration-branch: autoland
gecko-reviewers: hiro
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 14, 2018

Build ERRORED

Started: 2018-02-14 20:20:21
Finished: 2018-02-14 20:37:11

Failing Jobs

  • firefox:nightly
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Firefox Nightly"

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/web-animations/timing-model/animations/canceling-an-animation.html   OK: 10
  A pause-pending ready promise should be rejected when the animation is canceled PASS: 10
  A play-pending ready promise should be rejected when the animation is canceled PASS: 10
  The cancel event should NOT be fired if the animation is already idle PASS: 1
FAIL: 9
assert_unreached: Cancel event should not be fired Reached unreachable code
  The finished promise should NOT be rejected if the animation is already idle FAIL: 10
assert_unreached: Finished promise should not reject Reached unreachable code
  The ready promise should be replaced when the animation is canceled PASS: 10
  When an animation is canceled, it should create a resolved Promise PASS: 10
@birtles

This comment has been minimized.

Copy link
Contributor

birtles commented Feb 14, 2018

That's not a new test and shouldn't block this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.