Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeouts in WPT AudioParam tests #9524

Merged
merged 1 commit into from
Feb 16, 2018

Commits on Feb 16, 2018

  1. Fix timeouts in WPT AudioParam tests

    Replace the tests that are using ScriptProcessor and online contexts
    with an offline context and verify all the output values instead of
    just one.
    
    This change exposed a couple of issues:
      - setTargetAtTime wasn't actually testing setTargetAtTime because a
        linearRampToValueAtTime event was called at the same time,
        effectively replacing the setTargetAtTime event
      - linearRampToValue and exponentialRampToValue tests expose bugs in
        Chrome's implementation of these when the event is scheduled in
        the past, and there is no preceding event.
    
    Bug: 812285, 626703
    Change-Id: Iad3f54dd4373411431c019de44d4c3bad07587ff
    Reviewed-on: https://chromium-review.googlesource.com/919151
    Commit-Queue: Raymond Toy <rtoy@chromium.org>
    Reviewed-by: Hongchan Choi <hongchan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#537311}
    Raymond Toy authored and chromium-wpt-export-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    c8efc17 View commit details
    Browse the repository at this point in the history