[LayoutNG] Use containing block size correctly for abspos. #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 20, 2018
Build PASSEDStarted: 2018-02-20 23:46:47 Failing Jobs
View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-926004
branch
from
3a4108d
to
0881bd9
Compare
UpdateOutOfFlowBlockLayout() needs to deal with both the actual containing block size, as specified by CSS (i.e. the padding box size), and the border-box size of the object that is the containing block of an absolutely positioned descendant. Some light cleanup. We always need the border sizes, so just calculate them once, unconditionally. Also, there seems no need for a special path for grid/flex, so I removed it. Some tests start to pass. All but one are still expected to fail in legacy. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I85462d76aa9fa3d0105bf079e59f7c2a7a70f117 Reviewed-on: https://chromium-review.googlesource.com/926004 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#537918}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-926004
branch
from
0881bd9
to
ec63767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateOutOfFlowBlockLayout() needs to deal with both the actual
containing block size, as specified by CSS (i.e. the padding box size),
and the border-box size of the object that is the containing block of an
absolutely positioned descendant.
Some light cleanup. We always need the border sizes, so just calculate
them once, unconditionally. Also, there seems no need for a special path
for grid/flex, so I removed it.
Some tests start to pass. All but one are still expected to fail in legacy.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I85462d76aa9fa3d0105bf079e59f7c2a7a70f117
Reviewed-on: https://chromium-review.googlesource.com/926004
Reviewed-by: Aleks Totic atotic@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#537918}