Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tab-under] Add tentative WPT for tab-under blocking #9632

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 22, 2018

This CL adds a basic test for tab-under blocking: ensuring that the
simplest tab-under navigations are blocked.

Note that since the popup blocker and tab-under blocker are implemented
in the //chrome layer, these tests are expected to fail using
content_shell.

Bug: 814357
Change-Id: I70c46c01208aabca68881c7a7ab476464200b6e1
Reviewed-on: https://chromium-review.googlesource.com/930542
WPT-Export-Revision: 3ef92cdad705dbd34f0c10839ecc9b2b9cd1b6cc

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Feb 22, 2018

Build PASSED

Started: 2018-02-23 16:03:48
Finished: 2018-02-23 16:10:15

Failing Jobs

  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Microsoftedge 16.16299" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/html/browsers/browsing-the-web/navigating-across-documents/tab-under/block-tab-under.tentative.sub.html   TIMEOUT: 9
OK: 1
  Tab-unders are blocked FAIL: 1
assert_not_equals: unable to open a new window got disallowed value null

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-930542 branch 2 times, most recently from b90cad6 to 37ec701 Compare February 22, 2018 22:21
This CL adds a basic test for tab-under blocking: ensuring that the
simplest tab-under navigations are blocked.

Note that since the popup blocker and tab-under blocker are implemented
in the //chrome layer, these tests are expected to fail using
content_shell.

Bug: 814357
Change-Id: I70c46c01208aabca68881c7a7ab476464200b6e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants