Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Whitelist supported properties. #9738

Merged
merged 1 commit into from Mar 2, 2018

Commits on Mar 2, 2018

  1. [css-typed-om] Whitelist supported properties.

    This patch whitelists all our supported properties. Any property that
    is not supported will return a base CSSStyleValue. This ensures that
    we don't accidentally produce unexpected results for properties that
    we haven't tested it.
    
    We also add a few new properties to support, bringing the total number
    of property tests to 50. We also remove support for 'z-index' because
    it uses <integers> which we don't support yet.
    
    transition-duration is failing tests because we currently convert
    ms to seconds when we compute, which is incorrect.
    
    Some paint/layout tests depend on properties that are not whitelisted,
    so we've changed them:
    - border-radius -> margin-left
    - align-items -> empty-cell
    
    Bug: 816402
    Change-Id: I84d2fd8a15df92624122f0c1ecf4f7c42f928928
    Reviewed-on: https://chromium-review.googlesource.com/942651
    Reviewed-by: nainar <nainar@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#540397}
    darrnshn authored and chromium-wpt-export-bot committed Mar 2, 2018
    Copy the full SHA
    4759c3b View commit details
    Browse the repository at this point in the history