-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the shape-detection-api IDL file #9832
Update the shape-detection-api IDL file #9832
Conversation
Build PASSEDStarted: 2018-03-08 06:04:19 View more information about this build on: |
d484168
to
b675d93
Compare
@yellowdoge, are you happy to be the suggested reviewer for this directory? Also, should it be "shape-detection-api" or just "shape-detection"? Which is most likely to become the /TR/ name is better, and then it'd be ideal to rename the current spec repo as well. |
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
@foolip, 👍 to having my handle as reviewer. Re. naming, all code in Chromium has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
When you rename a GitHub repo, github.com URLs will redirect, but it seems like github.io URLs do not. So if you would like to rename the spec repo, then doing so sooner rather than later is good. @yellowdoge, can you make a decision on that, so that we make the directory name here match? |
Should I merge this as-is and we follow up with a rename if needed? |
Sure, let's bet on the shorter name being the final one. |
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/
directory (instead of inline copies in the test files).