Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the shape-detection-api IDL file #9832

Conversation

5 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 06:04:19
Finished: 2018-03-08 06:14:14

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-shape-detection-api branch from d484168 to b675d93 Mar 7, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring requested a review from foolip Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 18, 2018

@foolip foolip requested review from yellowdoge and removed request for jensl and yuki3 Jun 19, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 19, 2018

@yellowdoge, are you happy to be the suggested reviewer for this directory? Also, should it be "shape-detection-api" or just "shape-detection"? Which is most likely to become the /TR/ name is better, and then it'd be ideal to rename the current spec repo as well.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jun 19, 2018

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@yellowdoge

This comment has been minimized.

Copy link
Contributor

yellowdoge commented Jun 19, 2018

@foolip, 👍 to having my handle as reviewer. Re. naming, all code in Chromium has shape-detection (no _api), but there are links and whatnot in the code pointing to the _api URLs. If we want to change it, it needs to happen soon. WDYT?

@yellowdoge
Copy link
Contributor

yellowdoge left a comment

👍

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 19, 2018

When you rename a GitHub repo, github.com URLs will redirect, but it seems like github.io URLs do not. So if you would like to rename the spec repo, then doing so sooner rather than later is good.

@yellowdoge, can you make a decision on that, so that we make the directory name here match?

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 21, 2018

Should I merge this as-is and we follow up with a rename if needed?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 21, 2018

Sure, let's bet on the shorter name being the final one.

@foolip foolip merged commit 3f54c29 into web-platform-tests:master Jun 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jun 21, 2018

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 26, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-shape-detection-api branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.