migrate urlsafe-base64 to be internal to web-push

[hikarunoryoma]

Solves: #785

[marco-c]

LGTM, could you rebase?

[hikarunoryoma]

LGTM, could you rebase?

Done! :)

Let me know if you want me to bump the version number. I was unsure how that is managed

[marco-c]

There seems to be one reference left to fix:

> node ./node_modules/eslint/bin/eslint --ignore-path .gitignore '.'


/home/runner/work/web-push/web-push/test/test-vapid-helper.js
Error:   18:26  error  'urlBase64' is not defined  no-undef

✖ 1 problem (1 error, 0 warnings)

[marco-c]

Unfortunately it looks like the tests are failing

[hikarunoryoma]

Thanks, I'll look to investigate this weekend and actually have JVM and run these test locally on my machine

[marco-c]

@hikarunoryoma still planning on working on this?

[haouarihk]

when is this gonna get merged.

Thanks for the hard work

[marco-c]

when is this gonna get merged.

Thanks for the hard work

There are some failing tests, they need to be fixed first before this can be merged.

[haouarihk]

i fixed the issue with decode
@hikarunoryoma
#813

[marco-c]

Merged in #813, thank you!