-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the #786 #812
Fix for the #786 #812
Conversation
i hate macos 16 for this |
i just corrected a little mistake @hikarunoryoma made with but instead it should be |
.nyc_output | ||
|
||
# ignore history | ||
.history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes in .gitignore are OK, but can you create a separate PR for them? I prefer to have self-contained PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, thank you for working on the PR!
BTW, you don't need to close and create a new one, you can also just update an existing PR.
|
||
if (publicKey.length !== 65) { | ||
throw new Error('Vapid public key should be 65 bytes long when decoded.'); | ||
throw new Error(`Vapid public key should be 65 bytes long when decoded. got (${publicKey.length}) ${publicKey}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new Error(`Vapid public key should be 65 bytes long when decoded. got (${publicKey.length}) ${publicKey}`); | |
throw new Error(`Vapid public key should be 65 bytes long when decoded, got (${publicKey.length}) ${publicKey}`); |
Thanks for addressing here! |
FIxed the issue with decode #786