Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "aes128gcm" ( RFC 8291 ) #70

Closed
xuwei-k opened this issue Oct 15, 2018 · 3 comments
Closed

Support "aes128gcm" ( RFC 8291 ) #70

xuwei-k opened this issue Oct 15, 2018 · 3 comments

Comments

@xuwei-k
Copy link
Contributor

xuwei-k commented Oct 15, 2018

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Oct 15, 2018

Should we use google/tink? 🤔

@martijndwars
Copy link
Member

For supporting aes128gcm I suggest we adopt similar changes to web-push-libs/web-push#309. We can use google/tink for the cryptographic operations. I can make the changes this weekend.

@xuwei-k xuwei-k mentioned this issue Nov 8, 2018
Closed
@martijndwars
Copy link
Member

Fixed in #72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support aes128gcm xuwei-k/webpush-java
2 participants
@xuwei-k @martijndwars