Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove track numbers from YouTube title #2466

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Remove track numbers from YouTube title #2466

merged 2 commits into from
Jul 3, 2020

Conversation

stephanebruckert
Copy link
Contributor

@stephanebruckert stephanebruckert commented Jun 30, 2020 •
edited

Describe the changes you made
Solves #2272

Additional context
Regex used: https://regex101.com/r/gHh2TB/5

@alexesprit
Copy link
Member

Could you add test cases where a video title should not be changed?

alexesprit
alexesprit reviewed Jun 30, 2020
View reviewed changes
tests/content/util.js Outdated Show resolved Hide resolved
inverse
inverse reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

src/core/content/util.js Outdated Show resolved Hide resolved
tests/content/util.js Show resolved Hide resolved
@stephanebruckert
Copy link
Contributor Author

@alexesprit @inverse, thanks for the review, I applied your feedback

alexesprit
alexesprit approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@alexesprit alexesprit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alexesprit
Copy link
Member

@inverse Have you any suggestions?

@alexesprit alexesprit linked an issue Jul 1, 2020 that may be closed by this pull request
Strip out track numbers from YouTube titles #2272
Closed
@alexesprit alexesprit added connector This issue or pull request is related to connectors core This issue or pull request is related to the extension core feature New feature or request labels Jul 2, 2020
@alexesprit alexesprit changed the title Remove track numbers from YT titles, solves #2272 Remove track numbers from YouTube title Jul 2, 2020
@alexesprit alexesprit merged commit e0b49e3 into web-scrobbler:master Jul 3, 2020
@stephanebruckert
Copy link
Contributor Author

@alexesprit I would love a patch release for this if you get a chance 🙏

@alexesprit
Copy link
Member

I think I will publish v2.33.0 instead.

@stephanebruckert
Copy link
Contributor Author

@alexesprit nice one, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inverse inverse inverse left review comments

@alexesprit alexesprit alexesprit approved these changes

Assignees
No one assigned
Labels
connector This issue or pull request is related to connectors core This issue or pull request is related to the extension core feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strip out track numbers from YouTube titles
3 participants
@stephanebruckert @alexesprit @inverse