Add Piped connector #3518
Merged
Add Piped connector #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inverse
reviewed
Dec 23, 2022
|
My bad! Thanks for the feedback. |
inverse
added
new-feature
inverse
approved these changes
Dec 24, 2022
| }; | ||
|
|
||
| Connector.getCurrentTime = () => | ||
| document.querySelector('.shaka-video').currentTime; |
There was a problem hiding this comment.
This could be extracted into a common variable to avoid duplication and improve refactoring later - but it's not a deal breaker breaker :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you made
This PR adds a connector for Piped. Resolves #3241
Additional context
I only include the official instance (piped.video). Like invidious, there are multiple instances (that change), so it would probably make more sense for people to add custom URLs.