Add connector for copyparty #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @9001 thanks for the contribution! Unfortunately we just released v3 of the extension which went through a whole TypeScript rewrite. The code is pretty much the same except requires Also the Let me know if you need help |
|
Nice, congratulations on v3 🎉 can't wait to see the new settings UI! I have rebased the branch on master; just let me know if it would be preferable to scrap the branch entirely and start afresh :> |
inverse
added
new-feature
|
Looks like something went wrong as there is still conflicts + lots of changes :/ Might be worth applying your changes fresh against the our master? |
|
Sorry about that!! Think I got it right this time :> |
hornbuckle
reviewed
Apr 5, 2023
* better np_url retrieval
hornbuckle
reviewed
Apr 5, 2023
* actually retrieve np_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you made
This adds support for copyparty, a self-hosted file sharing service. As most copyparty instances are for private use, I've included patterns for the public demo server and for the default port when running the server locally.
These changes will work on all copyparty versions starting from v1.6.11 onwards. If you'd like to test the changes, please drop by the demo server :>
Additional context
The same metadata is available through the media session api; however, the album cover URL inside the mediasession tags has a login token included as a URL parameter. Since everything works as expected even without this token, it felt like a good idea to strip it away before passing the image URL to the extension.