Add permission request to settings #3649
Conversation
yayuyokitano
added
new-feature
|
As some context on why I have made the decision I have made regarding how to trigger, browser.permissions.request must be triggered by a user action |
| hasPermissions(setPerms); | ||
|
|
||
| return ( | ||
| <Show when={!perms()}> |
There was a problem hiding this comment.
How does this work? how does perms() know what perms are set?
There was a problem hiding this comment.
perms is the getter function of a signal
The signal is set to true by default, then the signal setter setPerms is uses to set it to false if perms are not granted, and set back to true if the user grants permission.
Signals allow the component to be reactive – solid only renders the component once, so if you just use a raw variable it will not change what is rendered when you change the variable value. Signals (and other similar solid utilities) tell the component to actually change what is rendered too.
There was a problem hiding this comment.
Thanks for the explanation thought it was something like that :)
Adds a popup-esque thing on top of settings that asks the user to give host permissions if they didn't already. Helps a bit with UX, since this permission is no longer automatically granted in firefox/safari with manifest V3.