-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permission request to settings #3649
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { Setter, Show, createSignal } from 'solid-js'; | ||
import browser from 'webextension-polyfill'; | ||
import styles from './components.module.scss'; | ||
import { t } from '@/util/i18n'; | ||
|
||
const desiredPermissions = { | ||
origins: ['http://*/', 'https://*/'], | ||
}; | ||
|
||
export default function Permissions() { | ||
const [perms, setPerms] = createSignal(true); | ||
hasPermissions(setPerms); | ||
|
||
return ( | ||
<Show when={!perms()}> | ||
<div class={styles.permissionsPopup}> | ||
<button | ||
type="button" | ||
onClick={() => { | ||
// This is inline and not async, as when it was not there were some issues with safari isTrusted | ||
browser.permissions | ||
.request(desiredPermissions) | ||
.then(setPerms); | ||
}} | ||
> | ||
{t('optionsPermissionsLabel')} | ||
</button> | ||
</div> | ||
</Show> | ||
); | ||
} | ||
|
||
async function hasPermissions(setPerms: Setter<boolean>) { | ||
setPerms(await browser.permissions.contains(desiredPermissions)); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work? how does
perms()
know what perms are set?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perms is the getter function of a signal
The signal is set to true by default, then the signal setter setPerms is uses to set it to false if perms are not granted, and set back to true if the user grants permission.
Signals allow the component to be reactive – solid only renders the component once, so if you just use a raw variable it will not change what is rendered when you change the variable value. Signals (and other similar solid utilities) tell the component to actually change what is rendered too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation thought it was something like that :)