Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tx support + pull updated translations #3657

Merged
merged 11 commits into from Apr 20, 2023
Merged

Add tx support + pull updated translations #3657

merged 11 commits into from Apr 20, 2023

Conversation

inverse
Copy link
Member

@inverse inverse commented Apr 17, 2023 •
edited

Describe the changes you made

Got tx command line working to pull/push from the repo.

Perhaps should document the manual steps in https://github.com/web-scrobbler/web-scrobbler/wiki/Translate-the-extension

Additional context

inverse
inverse commented Apr 17, 2023
View reviewed changes
.tx/config Show resolved Hide resolved
@inverse inverse added skip-changelog Used for skipping being included in changelog minor-change For minor changes labels Apr 17, 2023
@inverse inverse changed the title Add tx support Add tx support + pull changes Apr 17, 2023
yayuyokitano
yayuyokitano requested changes Apr 19, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
scripts/translations-prepare.ts Outdated Show resolved Hide resolved
inverse
inverse commented Apr 19, 2023
View reviewed changes
src/_locales/de/privacy.md Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this file is being pulled there are zero translations here :/

yayuyokitano
yayuyokitano requested changes Apr 20, 2023
View reviewed changes
src/_locales/zh/messages.json Outdated Show resolved Hide resolved
@inverse inverse changed the title Add tx support + pull changes Add tx support + pull updated translations Apr 20, 2023
@inverse inverse added updated For things that were updated, e.g. connectors, icons and removed skip-changelog Used for skipping being included in changelog labels Apr 20, 2023
yayuyokitano
yayuyokitano approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@yayuyokitano yayuyokitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously theres still the issue of the "german" privacy.md that suddenly appeared, but i also dont think it really affects anything

@inverse
Copy link
Member Author

inverse commented Apr 20, 2023

Yeah that one's an odd one :/ I still don't understand why that was pulled but yeah doesnt break anything :/

@inverse inverse merged commit 0b0a629 into web-scrobbler:master Apr 20, 2023
10 checks passed
@inverse inverse deleted the add-tx-support branch November 11, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yayuyokitano yayuyokitano yayuyokitano approved these changes

Assignees
No one assigned
Labels
minor-change For minor changes updated For things that were updated, e.g. connectors, icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inverse @yayuyokitano