Change main logo #3746
Merged
Change main logo #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayuyokitano
added
core
|
Looks great to me (haven't tried building yet). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new logo is necessary for approval to safari.
Replaces the main logo across src and xcode project, and makes a lot of updates to icon build scripts.
One not directly related change is a change to icon creation functions that specifies widths and heights an extra time. The lack of this was causing scaling bugs.
macos icon next to safari icon
General safari icon
Universal icon for non-safari browsers (both firefox and chromium)
Bigger version:
Realistically would close #2430 if acceptable.
Does not change action icons yet, though this should probably be done.