Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix information concerning deal polling on the about page #1042

Closed
alanshaw opened this issue Feb 25, 2022 · 3 comments · Fixed by #1381
Closed

Fix information concerning deal polling on the about page #1042

alanshaw opened this issue Feb 25, 2022 · 3 comments · Fixed by #1381
Assignees
@dchoi27
Labels
effort/quickwin kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@alanshaw
Copy link
Member

Once the deals are active, the Web3.Storage client polls to ensure that the relevant sectors are still available. In the event of an early termination (or a miner going offline), the Web3.Storage client will automatically add the relevant deals into the queue of upcoming deals to ensure at all times there are always a minimum of 5 copies of data being stored with Filecoin Storage Providers.
https://web3.storage/about/

This is incorrect. The client does not do this. Dagcargo maybe does something like this.

cc @ribasushi
@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Feb 25, 2022
@vasco-santos
Copy link
Contributor

@dchoi27 synced with @ribasushi and at least now we don't support it, even though dagcargo aspires to support it.

In the meantime we should rephrase this to not include it. And also it is a layer underneath the web3storage client.

What is you suggestion here? Focus more on Filecoin capabilitiy of proof of storage until we have a technical solution in place?

@olizilla
Copy link
Contributor

@dchoi27 should we just remove this text for now, until we make it true?

olizilla added a commit that referenced this issue May 30, 2022
@olizilla
chore: Remove deal polling copy
bdf91b0 
Fixes: #1042

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla mentioned this issue May 30, 2022
Merged
@dchoi27 dchoi27 mentioned this issue Jun 6, 2022
Draft
@dchoi27
Copy link
Contributor

dchoi27 commented Jun 6, 2022

Agreed we should get rid of the blurb for now. opened #1407 to address this - could use help getting rid of the blurb!

olizilla added a commit that referenced this issue Jun 20, 2022
@olizilla
chore: Remove deal polling copy (#1381)
b902f2e 
Fixes: #1042

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchoi27 dchoi27

Labels
effort/quickwin kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove deal polling copy web3-storage/web3.storage
4 participants
@olizilla @alanshaw @vasco-santos @dchoi27