feat: simple analytics #2110
feat: simple analytics #2110
Conversation
|
Here is a custom event getting fired. I was unable to test implementation on safari and firefox bc of a cors error which I believe will be solved on prod. |
|
do we have any write up about simple vs plausible ? |
|
@hugomrdias ultimately came down to the events tracking between the two. SA is about to release a complete overhaul of their funnels/goals/conversions feature that will allow the team to leverage this data per the original ticket. Plausible when I first started this task also didnt have visit duration as a metric (which it appears to now have implemented) |
| @@ -44,6 +45,15 @@ function AccordionSection({ active, toggle, toggleOnLoad, reportUID, slug, disab | |||
| reportUID(uid); | |||
| }, [reportUID, uid]); | |||
|
|
|||
| useEffect(() => { | |||
| if (open && header) { | |||
| const headerLabel = header.props.children.find(child => { | |||
There was a problem hiding this comment.
this is a litttttle funky - hard for me to tell whether it would be possible to use a Ref (or whether that would be cleaner) but curious if you considered that rather than searching through children? not a blocker, but figured it's worth raising for posterity
| @@ -27,6 +28,16 @@ const App = ({ Component, pageProps }) => { | |||
| <AppProviders authorizationProps={{ ...pageProps }}> | |||
| <Metadata {...pageProps} /> | |||
| <RestrictedRoute {...pageProps}> | |||
| <Script src="https://track.web3.storage/latest.js" data-hostname="web3.storage" data-ignore-pages="/callback" /> | |||
There was a problem hiding this comment.
what's the best place to understand what these scripts are doing? it would be helpful to have a comment in here with a pointer for folks who come later and are trying to figure out where scripts come from and how they work
.vscode/settings.json
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
should this be checked in? genuinely unfamiliar with conventions for this team/repo so this is a "I am not sure, teach me" question not a "I am skeptical" one ;-p
There was a problem hiding this comment.
I actually have a similar question. I was getting vscode plugin conflicts on all the imports and this seemed to solve it. I thought it may help but others but if this was just me I probably should ignore the settings from getting checked in.
🤖 I have created a release *beep* *boop* --- ## [2.33.0](website-v2.32.0...website-v2.33.0) (2022-12-01) ### Features * add tooltip to dashboard storage totals ([#2101](#2101)) ([2056ec6](2056ec6)), closes [#2081](#2081) * list and ability to delete psa request created though deleted tokens ([#2054](#2054)) ([e150d1f](e150d1f)) * simple analytics ([#2110](#2110)) ([4d5a1a0](4d5a1a0)) ### Bug Fixes * styles missing from custom storage form ([#2135](#2135)) ([04b66bc](04b66bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Swap countly for simple analytics.