-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simple analytics #2110
Merged
Merged
feat: simple analytics #2110
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
86c9172
feat: first pass on adding simple analytics
cmunns 7350703
fix: swap countly events with sa
cmunns 7a0c377
fix: swap countly events with sa cont
cmunns 9b80155
fix: lint error
cmunns 73cc3f6
fix: remove dev from sa script
cmunns 88a5acd
fix: lint errors
cmunns e85801a
fix: rename saEvent as export
cmunns 4195e42
fix: search-replace accidental
cmunns 616bde4
fix: remove vscode settings
cmunns File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"eslint.enable": false, | ||
"eslint.alwaysShowStatus": true | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/** @constant */ | ||
export const events = { | ||
LINK_CLICK_BANNER_NFTSTORAGE: 'linkClickBannerNFTStorage', | ||
LINK_CLICK_NAVBAR: 'linkClickNavbar', | ||
LINK_CLICK_FOOTER: 'linkClickFooter', | ||
// Used for CTAs that are only linking to other pages/resources | ||
CTA_LINK_CLICK: 'ctaLinkClick', | ||
// Other custom action events | ||
LOGIN_CLICK: 'loginClick', | ||
LOGOUT_CLICK: 'logoutClick', | ||
FILE_UPLOAD_CLICK: 'fileUploadClick', | ||
FILE_DELETE_CLICK: 'fileDeleteClick', | ||
FILES_NAVIGATION_CLICK: 'filesNavigationClick', | ||
FILES_REFRESH: 'filesRefreshClick', | ||
TOKEN_CREATE: 'tokenCreate', | ||
TOKEN_COPY: 'tokenCopy', | ||
TOKEN_DELETE: 'tokenDelete', | ||
NOT_FOUND: 'notFound', | ||
FEEDBACK_HELPFUL: 'feedbackHelpful', | ||
FEEDBACK_IMPORTANT: 'feedbackImportant', | ||
FEEDBACK_GENERAL: 'feedbackGeneral', | ||
}; | ||
|
||
/** @constant */ | ||
export const ui = { | ||
HOME_HERO: 'home/hero', | ||
HOME_GET_STARTED: 'home/get-started', | ||
NAVBAR: 'navbar', | ||
LOGIN: 'login', | ||
FILES: 'files', | ||
UPLOAD: 'upload', | ||
NEW_TOKEN: 'new-token', | ||
TOKENS: 'tokens', | ||
TOKENS_EMPTY: 'tokens/empty', | ||
PROFILE_GETTING_STARTED: 'profile/getting-started', | ||
PROFILE_API_TOKENS: 'profile/api-tokens', | ||
}; | ||
|
||
export default { | ||
events, | ||
ui | ||
}; | ||
|
||
export const saEvent = (eventName, metadata) => { | ||
|
||
// @ts-ignore | ||
if (window && window.sa_event) return window.sa_event(eventName, metadata); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be checked in? genuinely unfamiliar with conventions for this team/repo so this is a "I am not sure, teach me" question not a "I am skeptical" one ;-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have a similar question. I was getting vscode plugin conflicts on all the imports and this seemed to solve it. I thought it may help but others but if this was just me I probably should ignore the settings from getting checked in.