fix: set client default chunk size to 50MB #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/set-client-default-chunk-size-to-50mb
branch
from
60c9bf5
to
eddad31
Compare
vasco-santos
force-pushed
the
fix/set-client-default-chunk-size-to-50mb
branch
from
eddad31
to
17273cb
Compare
alanshaw
approved these changes
Feb 28, 2023
vasco-santos
pushed a commit
that referenced
this pull request
Feb 28, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.1](web3.storage-v4.5.0...web3.storage-v4.5.1) (2023-02-28) ### Bug Fixes * set client default chunk size to 50MB ([#2227](#2227)) ([e34c2ac](e34c2ac)) * upload and pin table refactor ([#2018](#2018)) ([cbfe9d7](cbfe9d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
83 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per talk async with @alanshaw , setting default chunk size to 50MB to save us 5x in number of indexes needed to write/read R2