Skip to content

fix: upload and pin table refactor#2018

Merged
joshJarr merged 26 commits into
mainfrom
fix/upload-and-pin-table-refactor
Oct 17, 2022
Merged

fix: upload and pin table refactor#2018
joshJarr merged 26 commits into
mainfrom
fix/upload-and-pin-table-refactor

Conversation

@joshJarr

@joshJarr joshJarr commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

WIP: Refactoring the table renderer for uploads and pins.

TODO:

  • Ensure responsive behaviour on mobile
  • Add "edit" upload name functionality
  • Add select row functionality
  • Add delete Upload functionality
  • Add delete many functionality
  • Refactor Pins table

@joshJarr joshJarr self-assigned this Oct 10, 2022
@joshJarr joshJarr linked an issue Oct 10, 2022 that may be closed by this pull request
Comment thread packages/website/components/table/table.js Outdated
@github-actions

github-actions Bot commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

@joshJarr joshJarr changed the title Fix/upload and pin table refactor fix/upload and pin table refactor Oct 14, 2022
Comment thread packages/website/components/account/filesManager/uploadsTable.js Outdated
@joshJarr joshJarr changed the title fix/upload and pin table refactor fix: upload and pin table refactor Oct 14, 2022
@joshJarr
joshJarr marked this pull request as ready for review October 14, 2022 10:01

@flea89 flea89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some early feedback, while I go through the uploadsTable.js

Comment thread packages/website/components/account/filesManager/fileRowItem.js Outdated
Comment thread packages/website/components/table/table.js Outdated
Comment thread packages/website/components/account/filesManager/uploadsTable.js
Comment thread packages/website/components/account/filesManager/uploadsTable.js Outdated

@flea89 flea89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @joshJarr ! Let's get this out.

@joshJarr
joshJarr merged commit cbfe9d7 into main Oct 17, 2022
@joshJarr
joshJarr deleted the fix/upload-and-pin-table-refactor branch October 17, 2022 14:13
joshJarr pushed a commit that referenced this pull request Oct 17, 2022
🤖 I have created a release *beep* *boop*
---


##
[2.27.0](website-v2.26.0...website-v2.27.0)
(2022-10-17)


### Features

* status docs
([#1937](#1937))
([5fde787](5fde787))


### Bug Fixes

* no more request storage in docs
([#2029](#2029))
([59715d9](59715d9))
* upload and pin table refactor
([#2018](#2018))
([cbfe9d7](cbfe9d7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vasco-santos pushed a commit that referenced this pull request Feb 28, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.5.1](web3.storage-v4.5.0...web3.storage-v4.5.1)
(2023-02-28)


### Bug Fixes

* set client default chunk size to 50MB
([#2227](#2227))
([e34c2ac](e34c2ac))
* upload and pin table refactor
([#2018](#2018))
([cbfe9d7](cbfe9d7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the Uploads and Pin tables with the new Table component

2 participants