Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-core-requestmanager: Use sendAsync when available in sendBatch #1201

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

iamdoron
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 27, 2017

Coverage Status

Coverage remained the same at 85.55% when pulling 48b73c7 on iamdoron:1.0 into 17e1631 on ethereum:1.0.

@frozeman
Copy link
Contributor

In new web3.js version the send IS async. so only send should be used. When the provider is added it should take care of making sure sendAsync is translated to send. So this logic should be rather there.

@iamdoron
Copy link
Contributor Author

iamdoron commented Nov 30, 2017

@frozeman Thanks for the reply. The problem is that some providers in the wild are not compatible, and you already doing it for regular send: https://github.com/iamdoron/web3.js/blob/48b73c70fe00745176a836725442f45ab5378e83/packages/web3-core-requestmanager/src/index.js#L129
(cf013f5)
my actual problem is when using the Ganache test provider, as it doesn't support send

@frozeman
Copy link
Contributor

Youre right, it added that as a fallback, when as i only change that for the web3.currentProvider which is already existing. Will merge,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants