Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLHttpRequest options handling improved #2564

Merged
merged 3 commits into from
Mar 25, 2019
Merged

XMLHttpRequest options handling improved #2564

merged 3 commits into from
Mar 25, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 25, 2019 •
edited

Description

Fixes #2559 #1802

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Mar 25, 2019
@nivida nivida changed the title createXMLHttpRequest method updated in ProvidersModuleFactory XMLHttpRequest options handling improved Mar 25, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.683% when pulling 169fceb on issue/2559 into 22a190c on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Mar 25, 2019
@nivida nivida merged commit 432df2a into 1.0 Mar 25, 2019
@nivida nivida deleted the issue/2559 branch March 25, 2019 14:54
This was referenced Mar 25, 2019
Closed
Closed
Closed
@zemse
Copy link

zemse commented Apr 27, 2019

what is the version of web3.js of this PR?

@zemse zemse mentioned this pull request Apr 28, 2019
Closed
@alcuadrado alcuadrado mentioned this pull request Sep 27, 2019
Closed
@cgewecke cgewecke mentioned this pull request Oct 8, 2019
Closed
@jakubgs jakubgs mentioned this pull request Dec 13, 2019
Closed
@zemse zemse mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web3@1.0.0-beta.50 (Webkit, Gecko) CORS Error
3 participants
@nivida @coveralls @zemse