Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): hexToNumberString prefix validation #2884

Merged
merged 1 commit into from
Jun 11, 2019
Merged

fix(utils): hexToNumberString prefix validation #2884

merged 1 commit into from
Jun 11, 2019

Conversation

yzevm
Copy link

@yzevm yzevm commented Jun 10, 2019

Description

Fixes #2184

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no warnings.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 95.745% when pulling 9062ddd on yegorzaremba:hotfix-hexToNumberString-prefix into 7a8b1fc on ethereum:1.0.

@nivida nivida merged commit aaf26c8 into web3:1.0 Jun 11, 2019
@yzevm yzevm deleted the hotfix-hexToNumberString-prefix branch September 7, 2019 14:56
@alcuadrado alcuadrado mentioned this pull request Sep 28, 2019
Closed
@cgewecke cgewecke mentioned this pull request Oct 1, 2019
Merged
This was referenced Jan 9, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hexToNumberString sometimes interprets string as decimal
3 participants
@yzevm @coveralls @nivida