Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Junaid/1xlibsfix #4231

Merged
merged 26 commits into from
Aug 19, 2021
Merged

Junaid/1xlibsfix #4231

merged 26 commits into from
Aug 19, 2021

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Aug 11, 2021 •
edited
Loading

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs added the 1.x 1.0 related issues label Aug 11, 2021
@render
Copy link

render bot commented Aug 11, 2021

Your Render PR Server URL is https://web3-js-pr-4231.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c49s1lpg7hpcpoptta40.

@coveralls
Copy link

coveralls commented Aug 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1135632490

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 285 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+2.9%) to 75.461%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 6 84.39%
packages/web3-core-method/lib/index.js 11 94.01%
packages/web3-eth-accounts/lib/index.js 25 85.89%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/utils.js 31 8.46%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-eth-accounts/src/index.js 105 26.2%
Totals Coverage Status
Change from base Build 1102626574: 2.9%
Covered Lines: 3195
Relevant Lines: 4008
💛 - Coveralls

@philknows philknows linked an issue Aug 11, 2021 that may be closed by this pull request
1.x Fix libs with vulnerabilities #4225
Closed
@jdevcs jdevcs marked this pull request as ready for review August 12, 2021 10:03
luu-alex
luu-alex previously approved these changes Aug 12, 2021
View reviewed changes
@jdevcs jdevcs linked an issue Aug 13, 2021 that may be closed by this pull request
1 low severity vulnerability #3823
Closed
@jdevcs jdevcs mentioned this pull request Aug 13, 2021
Closed
spacesailor24
spacesailor24 suggested changes Aug 14, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@spacesailor24
Don't default type = 0x0 for eth_sendTransaction and eth_sendRawTrans…
e1556ff 
…action (#4241)

* Remove type = 0x0 default

* Update gasPrice short circuit check

* Update tests - remove type: 0x0

* Update CHANGELOG

* Apply patch fix to web3-eth-accounts

* Remove tx type defaulting

* update CHANGELOG

* update failing test

* Remove unused import

* Add quick check that user can pass type, and it's retained
@spacesailor24
Release 1.5.2 (#4242)
44b72f8 
* Update CHANGELOG

* npm i && npm run build

* v1.5.2-rc.0

* v1.5.2
jdevcs and others added 9 commits August 16, 2021 12:36
@jdevcs jdevcs merged commit 8e8785e into 1.x Aug 19, 2021
@jdevcs jdevcs deleted the junaid/1xlibsfix branch August 19, 2021 10:41
spacesailor24 added a commit that referenced this pull request Aug 26, 2021
@spacesailor24
Add changes from #4231
0cb67d7
@spacesailor24 spacesailor24 mentioned this pull request Sep 10, 2021
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 13, 2021
Open
This was referenced Nov 24, 2021
Open
Open
Open
Open
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 28, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 15, 2022
Closed
@affiliatedkat affiliatedkat mentioned this pull request Feb 2, 2024
Open
@Manny27nyc Manny27nyc mentioned this pull request Feb 2, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Feb 2, 2024
Open
This was referenced Feb 3, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacesailor24 spacesailor24 spacesailor24 approved these changes

@GregTheGreek GregTheGreek Awaiting requested review from GregTheGreek

@luu-alex luu-alex Awaiting requested review from luu-alex luu-alex is a code owner

Assignees
No one assigned
Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.x Fix libs with vulnerabilities 1 low severity vulnerability
4 participants
@jdevcs @coveralls @spacesailor24 @luu-alex