Don't default type = 0x0 for eth_sendTransaction and eth_sendRawTransaction #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacesailor24
added
Bug
|
Your Render PR Server URL is https://web3-js-pr-4241.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4c40ck6fj33n6f44c90. |
Pull Request Test Coverage Report for Build 1131591968
💛 - Coveralls |
|
This pull request introduces 1 alert when merging fcb8a56 into b383a8e - view on LGTM.com new alerts:
|
GregTheGreek
approved these changes
Aug 15, 2021
Merged
jdevcs
added a commit
that referenced
this pull request
Aug 19, 2021
* fixed sec issue libs * karma upgrade for lib sec issue fix * upgrade lerna for sec issue fix * change log * removed node 8 web31x build tests * included node 14 and removed node 10 buildtestruns * Don't default type = 0x0 for eth_sendTransaction and eth_sendRawTransaction (#4241) * Remove type = 0x0 default * Update gasPrice short circuit check * Update tests - remove type: 0x0 * Update CHANGELOG * Apply patch fix to web3-eth-accounts * Remove tx type defaulting * update CHANGELOG * update failing test * Remove unused import * Add quick check that user can pass type, and it's retained * Release 1.5.2 (#4242) * Update CHANGELOG * npm i && npm run build * v1.5.2-rc.0 * v1.5.2 * Update CHANGELOG.md Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * Update CHANGELOG.md Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * Update CHANGELOG.md Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * changelog update * fixed sec issue libs * karma upgrade for lib sec issue fix * upgrade lerna for sec issue fix * change log * removed node 8 web31x build tests * included node 14 and removed node 10 buildtestruns * Update CHANGELOG.md Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * Update CHANGELOG.md Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * Update CHANGELOG.md Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * changelog update * packagelock update after rebase merge conflicts * min node is 11 * package lock fix Co-authored-by: jdevcs <junaid@chainsafe.io> Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
This was referenced Nov 24, 2021
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this PR,
eth_sendTransactionandeth_sendRawTransactionwould default to includetype = 0x0when creating the tx object. Now,typewill not be defaulted if EIP-1559 or EIP-2930 params aren't passedAddresses issues mentioned here
Supersedes #4240