Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different types for jsonInterface setter and getter #5645

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #5474

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@render
Copy link

render bot commented Nov 22, 2022

@avkos
Copy link
Contributor

avkos commented Nov 22, 2022

I see a problem here. If we change abi we need to regenerate methods to make correct types, especially for overloaded functions.

@Muhammad-Altabba
Copy link
Contributor Author

I see a problem here. If we change abi we need to regenerate methods to make correct types, especially for overloaded functions.

Actually, the exact same logic that is used the first time the ABI is provided, is used when assigning a new ABI to jsonInterface. So, there should be no issues. And I also have a test written to ensure that. However, if you still think there is a problem, could you please provide a coding sample? You may just modify the newly added test case to show the edge case you are pointing to.

Thanks in advance,

@Muhammad-Altabba Muhammad-Altabba requested review from jdevcs, nikoulai, avkos, luu-alex and spacesailor24 and removed request for nikoulai November 28, 2022 18:18
@Muhammad-Altabba Muhammad-Altabba merged commit 650a7ec into 4.x Nov 29, 2022
@Muhammad-Altabba Muhammad-Altabba deleted the fix/5474/use-different-types-for-jsonInterface-setter-and-getter branch November 29, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants