Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): upgrade-bn #7232

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat(docs): upgrade-bn #7232

merged 1 commit into from
Sep 9, 2024

Conversation

danforbes
Copy link
Contributor

Add a section in "Upgrade from 1.x" for BN vs BigInt

Closes #6705

Add a section in "Upgrade from 1.x" for `BN` vs `BigInt`

Closes #6705
Copy link

github-actions bot commented Sep 3, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.17 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 619.88 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 9e02d00 Previous: 9b32205 Ratio
processingTx 21476 ops/sec (±7.25%) 23392 ops/sec (±7.52%) 1.09
processingContractDeploy 38912 ops/sec (±7.62%) 40479 ops/sec (±6.69%) 1.04
processingContractMethodSend 15657 ops/sec (±7.30%) 16317 ops/sec (±6.87%) 1.04
processingContractMethodCall 27034 ops/sec (±8.19%) 27614 ops/sec (±8.40%) 1.02
abiEncode 42844 ops/sec (±6.90%) 46686 ops/sec (±6.17%) 1.09
abiDecode 30842 ops/sec (±7.22%) 31121 ops/sec (±7.84%) 1.01
sign 1548 ops/sec (±0.86%) 1556 ops/sec (±0.91%) 1.01
verify 362 ops/sec (±0.61%) 369 ops/sec (±0.48%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (9b32205) to head (9e02d00).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7232   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         216      216           
  Lines        8429     8429           
  Branches     2315     2315           
=======================================
  Hits         7966     7966           
  Misses        463      463           
Flag Coverage Δ
UnitTests 94.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@danforbes danforbes merged commit 75df267 into 4.x Sep 9, 2024
53 of 54 checks passed
@danforbes danforbes deleted the feat/docs/upgrade-bn branch September 9, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Add a section in "Upgrade from 1.x" for BN and bigint
2 participants