Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong rle encode when string looks like 0x[Numbers] #11

Closed
sc0Vu opened this issue Apr 20, 2018 · 0 comments
Closed

Wrong rle encode when string looks like 0x[Numbers] #11

sc0Vu opened this issue Apr 20, 2018 · 0 comments

Comments

@sc0Vu
Copy link
Member

sc0Vu commented Apr 20, 2018

If the string is 0x1234523623 or 0x[Numbers]
rlp encode retrun wrong data, because 0x was removed before calling toBuffer
Buffer will decode the string as numeric string.
sc0Vu added a commit to sc0Vu/rlp that referenced this issue Apr 20, 2018
@sc0Vu
Fix web3p#11
ace76b4
@sc0Vu sc0Vu mentioned this issue Apr 20, 2018
Merged
@sc0Vu sc0Vu closed this as completed in #12 Apr 20, 2018
sc0Vu added a commit that referenced this issue Apr 20, 2018
@sc0Vu
Merge pull request #12 from sc0Vu/fix-11
930dbea 
Fix #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sc0Vu