Skip to content

Commit

Permalink
Fix add name select input elements (#1114)
Browse files Browse the repository at this point in the history
* fix(input,select: added name to element

* added changeset file

---------

Co-authored-by: Johan Holm <johanholm@Johans-MBP.lan>
  • Loading branch information
johanMoralis and Johan Holm committed Jun 14, 2023
1 parent 44d67b5 commit b3cea3d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/curvy-emus-begin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@web3uikit/core': patch
---

fix(input,select): added name to element
2 changes: 2 additions & 0 deletions packages/core/src/lib/InputNew/Input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const Input: React.FC<IInputProps> = ({
errorMessage = 'Sorry this is not valid',
id,
label,
name,
onBlur,
onChange,
onFocus,
Expand Down Expand Up @@ -145,6 +146,7 @@ const Input: React.FC<IInputProps> = ({
maxLength={validation?.maxLength || props.maxLength}
min={validation?.min || props.min}
minLength={validation?.minLength || props.minLength}
name={name}
onBlur={(e) => onBlurEvent(e)}
onChange={(e) => onChangeEvent(e)}
onFocus={(e) => onFocusEvent(e)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const TraditionalSelect: React.FC<ISelectProps> = ({
errorMessage = '',
id = 'web3uikit-select',
label,
name,
onBlurTraditional,
onChange,
onChangeTraditional,
Expand Down Expand Up @@ -55,6 +56,7 @@ const TraditionalSelect: React.FC<ISelectProps> = ({
}
required={validation?.required}
value={value}
name={name}
>
<option disabled>{placeholder || 'Please choose'}</option>

Expand Down

0 comments on commit b3cea3d

Please sign in to comment.