Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add name select input elements #1114

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

johanMoralis
Copy link
Collaborator


name: 'Fix add name select input elements'
about: Adding name to the elements select and input

Issue Description

We are currently missing name from the elements select and input, this adds name to the element.

Solution Description

BEFORE:
Screenshot 2023-06-14 at 12 42 47

AFTER:
Screenshot 2023-06-14 at 12 21 38

BEFORE:
Screenshot 2023-06-14 at 12 14 09

AFTER:
Screenshot 2023-06-14 at 12 12 51

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2023

🦋 Changeset detected

Latest commit: d7119fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/core/dist/index.js 345.63 KB (+0.02% 🔺)
packages/icons/dist/index.es.js 152.8 KB (0%)
packages/web3/dist/index.js 1.51 MB (0%)
packages/web3uikit/dist/index.js 2 MB (+0.01% 🔺)

@johanMoralis johanMoralis merged commit b3cea3d into master Jun 14, 2023
7 checks passed
@johanMoralis johanMoralis deleted the fix-add-name-select-input-elements branch June 14, 2023 10:55
This was referenced Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant