Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only replacing 'components/' if it's at the start of the path name. #238

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Only replacing 'components/' if it's at the start of the path name. #238

merged 1 commit into from
Jul 31, 2017

Conversation

webark
Copy link
Owner

@webark webark commented Jul 31, 2017

In Ember, when you call a component, if the component is in the root components directory, you don't need to include that in the path when you call it in the template. However, there could be sometimes where you might have components/ in the pathname. This should fix those issues. Specifically, this will close #236 @rmmmp

…if it is what starts the path, not for nest options. This should be revisited with unification Closes #236
@webark webark merged commit 54e087e into webark:master Jul 31, 2017
@webark webark deleted the unique-component-names branch July 31, 2017 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work with -components sub-directory
1 participant