Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with -components sub-directory #236

Closed
mikkopaderes opened this issue Jul 27, 2017 · 6 comments · Fixed by #238
Closed

Doesn't work with -components sub-directory #236

mikkopaderes opened this issue Jul 27, 2017 · 6 comments · Fixed by #238

Comments

@mikkopaderes
Copy link

My pods currently has the following structure:

<route_name>/-components/<component_name>.

However, this doesn't work as the podNames array from this line includes <route_name>/-<component_name>.

I believe the components word is being removed for some reason leaving out just the dash (-).
@webark
Copy link
Owner

webark commented Jul 27, 2017

@rmmmp I was unaware that you could do that. How do you call your components in a template from that directory?

@mikkopaderes
Copy link
Author

@webark by using the full path.

e.g.

{{#my-route/-components/x-button}}Foo{{/my-route/-components/x-button}}

@webark
Copy link
Owner

webark commented Jul 27, 2017

@rmmmp cool. should be able to handle that then.

@webark
Copy link
Owner

webark commented Jul 27, 2017

i'll try to get to it soon.

@webark webark mentioned this issue Jul 31, 2017
Merged
webark added a commit that referenced this issue Jul 31, 2017
@webark
fix(component name parsing): only switching out the word 'compoent/' …
54e087e 
…if it is what starts the path, not for nest options. This should be revisited with unification Closes #236
@webark
Copy link
Owner

webark commented Jul 31, 2017

@rmmmp v0.3.5 has been released.

@mikkopaderes
Copy link
Author

Thanks a lot!

webark added a commit that referenced this issue Nov 2, 2017
@webark
Update CHANGELOG.md
92e74fc 
# Change Log

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

<a name="0.3.7"></a>
## [0.3.7](v0.3.6...v0.3.7) (2017-11-02)


### Features

* **manifest ordering:** updated broccoli style manifest to now have the order of files in the manifest be sorted first by depth, then by alphanumeric ([fd710bf](fd710bf))



<a name="0.3.6"></a>
## [0.3.6](v0.3.5...v0.3.6) (2017-11-01)



<a name="0.3.5"></a>
## [0.3.5](v0.3.4...v0.3.5) (2017-07-31)


### Bug Fixes

* **component name parsing:** only switching out the word 'component/' if it is what starts the path, not for nest options. This should be revisited with unification Closes [#236](#236) ([54e087e](54e087e))



<a name="0.3.4"></a>
## [0.3.4](v0.3.3...v0.3.4) (2017-06-01)


### Bug Fixes

* **ensure environment:** getting the 'root host', and using a shim if the find host method isn't present, Closes [#231](#231) ([09fa5ec](09fa5ec))



<a name="0.3.3"></a>
## [0.3.3](v0.3.2...v0.3.3) (2017-04-24)



<a name="0.3.2"></a>
## [0.3.2](v0.3.1...v0.3.2) (2017-04-05)


### Bug Fixes

* **style manifest:** updated to new brocoli-style-mainifest properties that are more explicit ([5e848ca](5e848ca))


### Features

* **optimization:** ability to use terse class names to reduce css size ([d53ead8](d53ead8))



<a name="0.3.1"></a>
## [0.3.1](v0.3.0...v0.3.1) (2017-03-30)


### Bug Fixes

* **npm dependencies:** published what was being used to compile multiple differnt css preprocessors into one. closes [#221](#221) ([a060942](a060942))



<a name="0.3.0"></a>
# [0.3.0](v0.2.12...v0.3.0) (2017-02-25)


### Features

* **extensible identifier:** moved the generation of the namespace identifier and if the class should be added to a mixin for easier extensibility ([e3c627b](e3c627b))



<a name="0.2.12"></a>
## [0.2.12](v0.2.11...v0.2.12) (2017-02-24)


### Bug Fixes

* **description:** removed pod specificity ([16eae3b](16eae3b))
* **scss @ rules:** now allowing namespaceing of rules deinfed inside of a scss @ for rule. Fixes [#216](#216) ([6840c5e](6840c5e))



<a name="0.2.11"></a>
## [0.2.11](v0.2.10...v0.2.11) (2017-02-03)


### Bug Fixes

* **documentation:** updated for readabitlity ([d354534](d354534))



<a name="0.2.10"></a>
## [0.2.10](v0.2.9...v0.2.10) (2017-01-26)


### Bug Fixes

* **plain css:** Due to the odd nature of 'glob', you can't have a set of just one item. ([fd0d770](fd0d770)), closes [#178](#178) [#204](#204)



<a name="0.2.9"></a>
## [0.2.9](v0.2.8...v0.2.9) (2017-01-16)


### Bug Fixes

* **nested addons:** no longer switching to the parent app so that addon's specific settings can be used ([849a72d](849a72d))



<a name="0.2.8"></a>
## [0.2.8](v0.2.7...v0.2.8) (2016-12-14)



<a name="0.2.7"></a>
## [0.2.7](v0.2.6...v0.2.7) (2016-12-01)


### Bug Fixes

* **namespacing:** no longer namespacing children of @ rules ([489f23f](489f23f)), closes [#191](#191)



<a name="0.2.6"></a>
## [0.2.6](v0.2.5...v0.2.6) (2016-12-01)


### Bug Fixes

* **ember-2.11:** moving to concatenating and reassigning the classnames in case a classname is already in the array before the init call per [@rwjblue](https://github.com/rwjblue) suggestion ([40113e6](40113e6))



<a name="0.2.5"></a>
## [0.2.5](v0.2.4...v0.2.5) (2016-12-01)


### Bug Fixes

* **ember-2.11:** now not pushing to the frozen classnames property, but reasigning it ([63274c0](63274c0))



<a name="0.2.4"></a>
## [0.2.4](v0.2.3...v0.2.4) (2016-11-22)



<a name="0.2.3"></a>
## [0.2.3](v0.2.2...v0.2.3) (2016-11-15)



<a name="0.2.2"></a>
## [0.2.2](v0.2.1...v0.2.2) (2016-11-05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only replacing 'components/' if it's at the start of the path name.
2 participants
@webark @mikkopaderes