loadNFTMarkers has incorrect onSuccess signature

[antokhio]

loadNFTMarkers has incorrect return signature

(method) ARControllerNFT.loadNFTMarkers(urlOrData: string[], onSuccess: (ids: number) => void, onError: () => void): Promise<[{
    id: number;
}]>

onSuccess: (ids: number) should be onSuccess: (ids: number[])

currently have to convert it to unknow first:

await controller?.loadNFTMarkers(markers, (ids:unknown) => {...}, ... )

[kalwalt]

Hi @antokhio have you a piece of code to test? currently with ARnft (see Worker.ts) i never had this issue https://github.com/webarkit/ARnft/blob/bf748f29af0ce694c2f8730115468a113fb884a4/src/Worker.ts#L104-L116

      ar.loadNFTMarkers(nftMarkerUrls, (id: number) => {
           let marker = ar.getNFTData(ar.id, 0);
           ctx.postMessage({ type: "markerInfos", marker: marker });
           ar.trackNFTMarkerId(id);
           console.log("loadNFTMarker -> ", id);
           console.log(id);
           ctx.postMessage({ type: "endLoading", end: true });
       }).catch((err: any) => {
           console.error("Error in loading marker on Worker", err);
       });


       ctx.postMessage({ type: "loaded", proj: JSON.stringify(cameraMatrix) });
   };

I think jsartoolkitNFT need some improves in type checking see for example the LoadNFTMarkers

jsartoolkitNFT/src/ARControllerNFT.ts

Lines 704 to 719 in 9277579

	async loadNFTMarkers(
	urlOrData: Array<string>,
	onSuccess: (ids: number) => void,
	onError: () => void
	) {
	let nft = await this.artoolkitNFT.addNFTMarkers(
	this.id,
	urlOrData,
	(ids: any) => {
	this.nftMarkerCount += ids.length;
	onSuccess(ids);
	},
	onError
	);
	return nft;
	}

at line 712

(ids: any) => {
...
}

I think this is really odd...

[antokhio]

@kalwalt here is WIP project, https://github.com/antokhio/react-three-jsartoolkitnft/blob/main/src/workers/arnft.worker.ts

Just to note, trying to make it an npm package, but i have issues with web worker bundling i can't sort out for a week or so ;)
The code should be working if you copy the worker js from npm package to public.

if you wanna test it, this minimum code to make it work:

function App() {
  return (
    <ARNFTCanvas>
      <ARNFTMarker markers={['/markers/pinball']} persisted>
        <Box args={[100, 100, 100]} />
      </ARNFTMarker>
      <ARNFTMarker markers={['/markers/insta']}>
        <Sphere args={[100, 100, 100]} />
      </ARNFTMarker>
    </ARNFTCanvas>
  );
}

p.s. there gonna be a bit of refactor/cleanup when i manage to make worker portable

[antokhio]

@kalwalt the problem is line 706

jsartoolkitNFT/src/ARControllerNFT.ts

Line 706 in 9277579

onSuccess: (ids: number) => void,

this prevents call with correct signature....
likely it's just misstyped

however according to this:

jsartoolkitNFT/src/ARControllerNFT.ts

Lines 100 to 105 in 9277579

	addNFTMarkers: (
	arId: number,
	urls: Array<string>,
	callback: (filename: any) => void,
	onError2: (errorNumber: any) => void
	) => [{ id: number }];

the return type should be:

{id: number}[]

not sure, looks like an error in both places actually
according to my code it returns:

{
   id: number;
   width: number;
   height: number;
   dpi: number;
}[]

[kalwalt]

@antokhio i will try to fix in a PR i hope soon.

[kalwalt]

with the latest in PR #231 it should works in this way:

await ar?.loadNFTMarkers(nftMarkerUrls, (id: number[]) => {
      let marker = ar.getNFTData(id[i], 0);
      ctx.postMessage({ type: "markerInfos", marker: marker });
      ar.trackNFTMarkerId(id[i]);
      console.log("loadNFTMarker -> ", id);
      console.log(id);
      ctx.postMessage({ type: "endLoading", end: true });
      }, () => {}).catch((err: string) => {
          console.error("Error in loading marker on Worker", err);
      });