Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Testing DGK with Signature Bridge (Phase 1) #156

Merged
merged 21 commits into from
Feb 17, 2022

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Feb 9, 2022

This is the first phase of the End to End Testing of the DKG System with Signature Bridge.

This Phase Covers the Following:

  • Set up a CI (Github Action) that will Compile, Run and Test the DKG with Signature Bridge.
  • Run an EVM Testnet and Deploy the Signature Bridge (along with other related contracts) on it.
  • Add Manual-sealing.
  • Add dkg.manual_refresh() call (for testing).
  • Test when the DKG Public Key changes on-chain that we update it also on the Signature Bridge contract.

The next Phase would cover other tests like other kinds of proposals, this phase is just a foundation or like infrastructure for other kinds of tests on the DKG.

@shekohex shekohex added ef5 testing 🛠️ Tasks that are related to testing labels Feb 9, 2022
@shekohex shekohex self-assigned this Feb 9, 2022
@shekohex shekohex marked this pull request as ready for review February 17, 2022 17:33
@codecov-commenter
Copy link

Codecov Report

Merging #156 (15ede94) into master (9b898b8) will decrease coverage by 0.50%.
The diff coverage is 1.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   63.16%   62.66%   -0.51%     
==========================================
  Files          65       65              
  Lines        8275     8343      +68     
==========================================
+ Hits         5227     5228       +1     
- Misses       3048     3115      +67     
Impacted Files Coverage Δ
dkg-runtime-primitives/src/proposal.rs 47.58% <0.00%> (-8.08%) ⬇️
node/src/service.rs 0.00% <0.00%> (ø)
pallets/dkg-mmr/src/lib.rs 0.00% <ø> (ø)
pallets/dkg-proposal-handler/src/lib.rs 54.02% <ø> (ø)
pallets/dkg-proposals/src/lib.rs 71.13% <ø> (ø)
pallets/parachain-staking/src/lib.rs 82.04% <ø> (ø)
standalone/node/src/rpc.rs 0.00% <0.00%> (ø)
standalone/runtime/src/lib.rs 0.00% <ø> (ø)
pallets/dkg-metadata/src/lib.rs 14.87% <2.50%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b898b8...15ede94. Read the comment docs.

@shekohex shekohex added the needs review 👓 Pull request needs a review label Feb 17, 2022
@drewstone drewstone merged commit 3dc9745 into master Feb 17, 2022
@drewstone drewstone deleted the shady/e2e-signature-bridge-phase1 branch February 17, 2022 20:28
@shekohex shekohex removed the needs review 👓 Pull request needs a review label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🛠️ Tasks that are related to testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants