-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile Errors using webbit-0.4.0-full.jar #78
Comments
Yup. I see what it is. Updating this now. The code which returns Futures in the Wiki also needs updating. |
If I understand correctly this is a documentation bug, not a bug in the webbit code, right? |
Yes. I've updated the README and the Javadoc for the |
I've now updated the relevant wiki pages as well. Should a new release be made for 4.0 because of the update to the |
An update in v4.0 meant that WebServer.start() and other related methods would produce a Future instead of returning 'this'. This change updates any old code examples to provide proper example usage.
Thanks guys. That was quick! Now compiles and runs fine. |
@aslakhellesoy Still same question, WRT a new release because of the change to the Javadoc. |
What's missing before we can close this? |
AFAICT it's all done. Just needs to have another release. |
Cool. Can you close this and update History.md? |
- create new named release - update changelog link - show what's been added to 0.4.3 since 0.4.2
Done. |
Trying to compile the Quick Start WebSocketHandler in the README.md against the webbit-0.4.0-full.jar.
Doing the same compile against the webbit-0.3.8-full.jar is OK.
In both cases I'm using Oracle's 1.6 JRE in the Eclipse IDE.
Think the WebSocketHandler example code needs updating for 0.4.0 as there is now an onPing method required and the existing onPong method now uses byte[] instead of String for message.
Also getting:
Type mismatch: cannot convert from Future<capture#1-of ? extends > WebServer>to WebServer
on the code that creates the WebServer.
Its the Type mismatch that has me completely stuck!!
The text was updated successfully, but these errors were encountered: