Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Errors using webbit-0.4.0-full.jar #78

Closed
philrob opened this issue Feb 15, 2012 · 10 comments
Closed

Compile Errors using webbit-0.4.0-full.jar #78

philrob opened this issue Feb 15, 2012 · 10 comments

Comments

@philrob
Copy link

philrob commented Feb 15, 2012

Trying to compile the Quick Start WebSocketHandler in the README.md against the webbit-0.4.0-full.jar.
Doing the same compile against the webbit-0.3.8-full.jar is OK.
In both cases I'm using Oracle's 1.6 JRE in the Eclipse IDE.

Think the WebSocketHandler example code needs updating for 0.4.0 as there is now an onPing method required and the existing onPong method now uses byte[] instead of String for message.

Also getting:

Type mismatch: cannot convert from Future<capture#1-of ? extends > WebServer>to WebServer

on the code that creates the WebServer.

Its the Type mismatch that has me completely stuck!!

@KushalP
Copy link
Contributor

KushalP commented Feb 15, 2012

Yup. I see what it is. Updating this now.

The code which returns Futures in the Wiki also needs updating.

@aslakhellesoy
Copy link
Member

If I understand correctly this is a documentation bug, not a bug in the webbit code, right?

@KushalP
Copy link
Contributor

KushalP commented Feb 15, 2012

Yes. I've updated the README and the Javadoc for the WebServer class. Just updating the relevant wiki page now as well. Will close this off shortly.

@KushalP
Copy link
Contributor

KushalP commented Feb 15, 2012

I've now updated the relevant wiki pages as well.

Should a new release be made for 4.0 because of the update to the WebServer javadoc? Does it need to be incremented, or can you just override the one already available on the maven repo?

KushalP added a commit that referenced this issue Feb 15, 2012
An update in v4.0 meant that WebServer.start() and other related methods
would produce a Future instead of returning 'this'.

This change updates any old code examples to provide proper example
usage.
@philrob
Copy link
Author

philrob commented Feb 15, 2012

Thanks guys. That was quick! Now compiles and runs fine.

@KushalP
Copy link
Contributor

KushalP commented Feb 15, 2012

@aslakhellesoy Still same question, WRT a new release because of the change to the Javadoc.

@aslakhellesoy
Copy link
Member

What's missing before we can close this?

@KushalP
Copy link
Contributor

KushalP commented Feb 15, 2012

AFAICT it's all done. Just needs to have another release.

@aslakhellesoy
Copy link
Member

Cool. Can you close this and update History.md?

KushalP added a commit to KushalP/webbit that referenced this issue Feb 15, 2012
- create new named release
- update changelog link
- show what's been added to 0.4.3 since 0.4.2
@KushalP
Copy link
Contributor

KushalP commented Feb 15, 2012

Done.

@KushalP KushalP closed this as completed Feb 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants