Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adf.ly - design is broken #11757

Open
winardiaris opened this issue Oct 6, 2017 · 5 comments
Open

adf.ly - design is broken #11757

winardiaris opened this issue Oct 6, 2017 · 5 comments
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-important q4-2019-outreach Tracking outreach in Q42019. Re-triaged Items re-triaged by Oana&Sergiu, to see which ones are still valid severity-minor The site has a cosmetic issue.
Milestone

Comments

@winardiaris
Copy link

URL: http://adf.ly/

Browser / Version: Firefox 57.0
Operating System: Linux
Tested Another Browser: Yes

Problem type: Design is broken
Description: different style color
Steps to Reproduce:
open http://adf.ly/ in firefox 57.0b5 and chrome 61.0.3163.91
scroll down and look at Join Now button
Screenshot Description

From webcompat.com with ❤️

@miketaylr
Copy link
Member

Interesting. It's kinda like the gradients are reversed.

.yellowButton, section.vertising section.rates table.rates .orderSummary input, table.campaign input[type="button"], table.campaign input[type="submit"] {
    margin-top: 15px;
    font-family: Arial,sans-serif;
    font-size: 21px;
    background-color: #ffdc70 !important;
    width: auto;
    height: 55px;
    color: #826f2f;
    border: 1px solid #bfa65a;
    border-radius: 3px;
    border-top-color: #ffffc1;
    border-right-color: #aa9249;
    border-bottom-color: #917b36;
    border-left-color: #ad964c;
    background-image: linear-gradient(bottom,#FFCA2A 1%,#FFE28A 51%);
    background-image: -o-linear-gradient(bottom,#FFCA2A 1%,#FFE28A 51%);
    background-image: -moz-linear-gradient(bottom,#FFCA2A 1%,#FFE28A 51%);
    background-image: -webkit-linear-gradient(bottom,#FFCA2A 1%,#FFE28A 51%);
    background-image: -ms-linear-gradient(bottom,#FFCA2A 1%,#FFE28A 51%);
    background-image: -webkit-gradient(linear,left bottom,left 2,color-stop(0.01,#FFCA2A),color-stop(0.51,#FFE28A) );
    text-shadow: 0 1px #ffffc1;
    box-shadow: 0 -1px #bfa65a;
    padding-left: 12px;
    padding-right: 12px;
}

(this might be due to our -webkit-gradient emulation, which isn't perfect, but there's a gradient. 😄 )

@karlcow karlcow added this to the needsdiagnosis milestone Oct 30, 2017
@softvision-sergiulogigan softvision-sergiulogigan added the Re-triaged Items re-triaged by Oana&Sergiu, to see which ones are still valid label Apr 20, 2018
@softvision-sergiulogigan

Looks like the issue is still around:

image

This is on Windows 10, Nightly 61 and Chrome 66.

Looks like disabling the background-image: -webkit-gradient( linear, left bottom, left 2, color-stop(0.01, #FFCA2A), color-stop(0.51, #FFE28A) ) property of the "Join Now" (for example), the gradient is corrected.

image

@karlcow
Copy link
Member

karlcow commented May 4, 2018

@softvision-sergiulogigan Good analysis.

Basically they should put the CSS property in the right order.

.yellowButton, section.vertising section.rates table.rates .orderSummary input, table.campaign input[type="button"], table.campaign input[type="submit"] {
	margin-top: 15px;
	font-family: Arial, sans-serif;
	font-size: 21px;
	background-color: #ffdc70 !important;
	width: auto;
	height: 55px;
	color: #826f2f;
	border: 1px solid #bfa65a;
	border-radius: 3px;
	border-top-color: #ffffc1;
	border-right-color: #aa9249;
	border-bottom-color: #917b36;
	border-left-color: #ad964c;
	background-image: linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -o-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -moz-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -webkit-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -ms-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -webkit-gradient( linear, left bottom, left 2, color-stop(0.01, #FFCA2A), color-stop(0.51, #FFE28A) );
	text-shadow: 0 1px #ffffc1;
	box-shadow: 0 -1px #bfa65a;
	padding-left: 12px;
	padding-right: 12px;
}

aka in the group

	background-image: linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -o-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -moz-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -webkit-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -ms-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -webkit-gradient( linear, left bottom, left 2, color-stop(0.01, #FFCA2A), color-stop(0.51, #FFE28A) );

they should put the standard one last.

	background-image: -o-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -moz-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -webkit-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -ms-linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);
	background-image: -webkit-gradient( linear, left bottom, left 2, color-stop(0.01, #FFCA2A), color-stop(0.51, #FFE28A) );
	background-image: linear-gradient(bottom, #FFCA2A 1%, #FFE28A 51%);

or even better just put the standard one :)

What is happening is that because of sites implementing only -webkit- stuff. Firefox had to implement an alias for -webkit-gradient and as it is the latest one in the list of CSS rules, the cascade is taken into account and is applied as it should.

Moving to needscontact

@karlcow
Copy link
Member

karlcow commented May 4, 2018

The contact page is tied to a login…
https://twitter.com/AdFly useless for contacting.
Maybe https://www.linkedin.com/in/ad-fly-3826b5129

@karlcow karlcow modified the milestones: needsdiagnosis, contactready May 4, 2018
@adamopenweb adamopenweb added the severity-minor The site has a cosmetic issue. label May 4, 2018
@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@karlcow
Copy link
Member

karlcow commented Dec 11, 2019

sent a message through linkedin.

@karlcow karlcow modified the milestones: contactready, sitewait Dec 11, 2019
@karlcow karlcow added the q4-2019-outreach Tracking outreach in Q42019. label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-important q4-2019-outreach Tracking outreach in Q42019. Re-triaged Items re-triaged by Oana&Sergiu, to see which ones are still valid severity-minor The site has a cosmetic issue.
Projects
None yet
Development

No branches or pull requests

6 participants