Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.kobo.com - design is broken #14152

Closed
webcompat-bot opened this issue Dec 10, 2017 · 8 comments
Closed

www.kobo.com - design is broken #14152

webcompat-bot opened this issue Dec 10, 2017 · 8 comments
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine type-stylo Firefox stylo engine
Milestone

Comments

@webcompat-bot
Copy link

URL: https://www.kobo.com/tw/zh/ebook/YruhfhJjrz63qyuRlZnoEQ

Browser / Version: Firefox 58.0
Operating System: Windows 10
Tested Another Browser: Yes

Problem type: Design is broken
Description: Priveiew is broken.
Steps to Reproduce:

layout.css.servo.enabled: true

Only a half content can be seen.
Screenshot Description

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone Dec 10, 2017
@karlcow
Copy link
Member

karlcow commented Dec 10, 2017

@MDTsai could you test? kobo has an agressive redirection policy depending on the country.

@reinhart1010
Copy link

I just found another interesting layout issue, which could be dependent on the viewport size. Here's what it looks from my laptop screen:

screenshot from 2017-12-11 16-13-12

and when I turned full screen mode on:

screenshot from 2017-12-11 16-13-18

However, by looking by the order of Traditional Chinese characters, I can confirm that this bug is also dependent on the viewport size. I am testing this site on Nightly 59 on Linux Mint 18.3 Cinnamon (Ubuntu 16.04.3), and "WenQuanYi Micro Hei" system font is being used to render these characters.

Opening the URL in Chrome 62 has another problem, where some of these characters are stacked. I think I should open another issue.

screenshot from 2017-12-11 16-20-30

Moved to needsdiagnosis.

@MDTsai
Copy link

MDTsai commented Dec 12, 2017

I get the same result as reporter's screenshot. I guess the iframe's column-width: 430px (for me) cause the text only render in half height, disable that looks good for me.

@karlcow
Copy link
Member

karlcow commented Apr 5, 2018

The content is coming from an iframe.

<iframe scrolling="no" id="epubContentIframe" style="position: relative; right: 0px; overflow: hidden; opacity: 1; width: 938px; height: 490px;"></iframe>

Let's figure out with outlines and background colors

  • nesting div for the iframe: red
  • html inside the iframe, background-color: gold.
  • body element: background-color: pink
  • outlines for body children: blue.

Screenshot Description

So we seem to get a body larger than the defined size for the iframe.

for the iframe.

element {
	position: relative;
	right: 0px;
	overflow: hidden;
	opacity: 1;
	width: 938px;
	height: 490px;
}

for the html

element {
	height: 490px;
	position: relative;
	font-size: 100%;
	column-gap: 60px;
	width: 938px;
	column-width: 439px;
	right: 0px;
}

for the body

element {
	background-color: rgba(0, 0, 0, 0);
	color: rgb(89, 89, 89);
}

no defined size for the body. but indeed it is very large: 2969.55px a lot wider than the width defined by the html.

if I'm adding a height: 100% in there, I get something better.

Screenshot Description

to note that both in Firefox and Chrome it doesn't solve all issues, there's missing horizontal text.

Switching to needscontact

@reinhart1010
Copy link

There's a English contact form at https://kobo.frontlinesvc.com/app/ask_NAform_T

@adamopenweb
Copy link
Collaborator

Completed the English form, fingers crossed! 🤞

@adamopenweb adamopenweb modified the milestones: contactready, sitewait Apr 6, 2018
@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@softvision-sergiulogigan

The issue is still reproducible on my side.

Tested with:
Browser / Version: Firefox Nightly 70.0a1 (2019-08-07)
Operating System: Windows 10 Pro

@reinhart1010
Copy link

This issue seems have been fixed, tested on Firefox 85.0.1.

(Apparently Kobo store previews are showing random, non-specific sections of the book)

image

As of Firefox 85 I am no longer able to find the layout.css.servo.enabled option on about:config, hence I assume that Stylo has already been enabled by default (for all builds of Firefox, though I'm aware it's rolling out since 57/Quantum).

@reinhart1010 reinhart1010 modified the milestones: sitewait, fixed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine type-stylo Firefox stylo engine
Projects
None yet
Development

No branches or pull requests

7 participants