New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delivery.panerabread.com - see bug description #15403
Comments
ping @miketaylr for a bit of diagnosis. It sounds related to angular and events. The original source code is an empty shell. (Thanks google cache) <div id="page-body" role="main">
<android-app-banner></android-app-banner>
<notification-banner></notification-banner>
<pnra-navbar></pnra-navbar>
<app-banner></app-banner>
<div ng-view ng-cloak autoscroll id="content"></div>
<pnra-footer></pnra-footer>
<noscript>Enable JavaScript to view this web page.</noscript>
</div> |
OK, yeah. I can't reproduce the bug as reported in Dev Edition 59, but can reproduce in Nightly 60. So let's use mozregression to see what's up:
Hmm...
|
In https://delivery.panerabread.com/scripts/app.min.js?682fbc2348a11e706cd066ca31470eaa
|
Hm, looks like a polyfill for https://developers.google.com/web/updates/2017/06/credential-management-updates#preventsilentaccess |
And the polyfill assumes
I don't see that we have this implemented in Firefox, so that would be a problem. But maybe that's not the problem, according to the stack trace in @softvision-oana-arbuzov's comment. Oh wait... we don't even get there. This bombs here: this.login = function() {
return a.isBrowserCompatible() ? (a.requireUserMediation(),
e.navigator.credentials.get({
password: !0,
mediation: "optional"
}).then(function(e) {
return e ? a.loginWithFetch(e) : n.reject()
})) : n.reject()
} Which calls: this.requireUserMediation = function() {
return a.isBrowserCompatible() ? e.navigator.credentials.preventSilentAccess() || e.navigator.credentials.requireUserMediation() : void 0
} Which calls:
So, since we now support So, the site is trying to do the right thing but failing. I'll file a bug in Bugzilla, because it's a site breaking "regression", but we should move to contactready because they're doing feature detection the wrong way. |
Thanks @miketaylr for the diagnosis. |
Let's close this bug in favor of https://bugzilla.mozilla.org/show_bug.cgi?id=1439805. |
URL: https://delivery.panerabread.com/
Browser / Version: Firefox 60.0
Operating System: Mac OS X 10.13
Tested Another Browser: Yes
Problem type: Something else
Description: Selecting one of the Rapid Pickup, Delivery, Order From My Table options does not give login overlay. Shows this iun console:
Steps to Reproduce:
gfx.webrender.all: false
gfx.webrender.blob-images: 1
gfx.webrender.enabled: false
image.mem.shared: 2
From webcompat.com with ❤️
The text was updated successfully, but these errors were encountered: