Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fortiguard.com - “Browse” button is displayed misaligned #16794

Closed
softvision-oana-arbuzov opened this issue May 8, 2018 · 5 comments
Closed
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-linux Issues only happening on Linux. priority-normal Re-triaged Items re-triaged by Oana&Sergiu, to see which ones are still valid severity-minor The site has a cosmetic issue. status-first-contact
Milestone

Comments

@softvision-oana-arbuzov
Copy link
Member

softvision-oana-arbuzov commented May 8, 2018

URL: https://fortiguard.com/faq/onlinescanner

Browser / Version: Firefox Mobile Nightly 62.0a1 (2018-05-07)
Operating System: Linux Ubuntu 16.04
Tested Another Browser: Yes

Problem type: Design is broken
Description: “Browse” button is displayed misaligned.

Steps to Reproduce:

  1. Navigate https://fortiguard.com/faq/onlinescanner
  2. Observe “Browse” button.

Expected Behavior:
Button is centered.

Actual Behavior:
Button is misaligned.

Note:

  1. Reproducible on Firefox 60.0 Release.
  2. Not reproducible on Chrome 66.0.3359.139.
  3. Screenshot attached.
  4. Affected area:
<input id="online_scanner_form_file" name="online_scanner_form[file]" required="required" class="form-control" type="file">

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov

sv; country: us
Screenshot Description

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone May 8, 2018
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title fortiguard.com - design is broken fortiguard.com - “Browse” button is displayed misaligned May 8, 2018
@softvision-oana-arbuzov
Copy link
Member Author

Removing height: 34px;, "Browse" button becomes centered and does not affect Chrome.

.form-control {
    display: block;
    width: 100%;
    height: 34px;
    padding: 6px 12px;
    font-size: 14px;
    line-height: 1.42857143;
    color: #555;
    background-color: #fff;
    background-image: none;
    border: 1px solid #ccc;
    border-radius: 4px;
    -webkit-box-shadow: inset 0 1px 1px rgba(0,0,0,.075);
    box-shadow: inset 0 1px 1px rgba(0,0,0,.075);
    -webkit-transition: border-color ease-in-out .15s,-webkit-box-shadow ease-in-out .15s;
    -o-transition: border-color ease-in-out .15s,box-shadow ease-in-out .15s;
    transition: border-color ease-in-out .15s,box-shadow ease-in-out .15s;
}

image

@karlcow can you confirm this?

@softvision-oana-arbuzov softvision-oana-arbuzov added browser-firefox priority-normal Re-triaged Items re-triaged by Oana&Sergiu, to see which ones are still valid labels May 8, 2018
@karlcow
Copy link
Member

karlcow commented May 9, 2018

yes removing the height will solve the issue and in this case, it saves no purpose be on chrome, safari or firefox. fwiw the issue is happening on desktop too.

The way the form widgets are affected are not really defined in CSS. What is happening here is that Firefox switches from a native widget to a CSS custom widget. Chrome/Safari just ignores the instruction for the widget size and grows the box only. Firefox grows the widget itself.

It's probably tied to the -webkit-appearance stuff. Partly.

@karlcow karlcow modified the milestones: needsdiagnosis, needscontact May 9, 2018
@karlcow
Copy link
Member

karlcow commented May 9, 2018

@adamopenweb adamopenweb added type-css Generic CSS issues and removed type-css Generic CSS issues labels May 28, 2018
@adamopenweb
Copy link
Collaborator

https://fortiguard.com/faq/generalcontact

Reaching out via site contact form.

@adamopenweb adamopenweb added severity-minor The site has a cosmetic issue. status-first-contact labels May 28, 2018
@adamopenweb adamopenweb modified the milestones: needscontact, sitewait May 28, 2018
@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@cipriansv cipriansv added the os-linux Issues only happening on Linux. label Jun 21, 2019
@softvision-oana-arbuzov
Copy link
Member Author

The issue has been fixed.
image

Tested with:
Browser / Version: Firefox Nightly 69.0a1 (2019-06-26)
Operating System: Linux Ubuntu 16.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-linux Issues only happening on Linux. priority-normal Re-triaged Items re-triaged by Oana&Sergiu, to see which ones are still valid severity-minor The site has a cosmetic issue. status-first-contact
Projects
None yet
Development

No branches or pull requests

6 participants