Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my.outbrain.com - Clear All button is not working #25225

Closed
softvision-sergiulogigan opened this issue Feb 1, 2019 · 5 comments
Closed

my.outbrain.com - Clear All button is not working #25225

softvision-sergiulogigan opened this issue Feb 1, 2019 · 5 comments
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-important severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. type-html Generic HTML issues
Milestone

Comments

@softvision-sergiulogigan
Copy link

softvision-sergiulogigan commented Feb 1, 2019

URL: https://my.outbrain.com/amplify/funnel/content

Browser / Version: Firefox Nightly 67.0a1 (2019-01-31) (Desktop)
Operating System: Windows 10
Tested Another Browser: Yes

Problem type: Site is not usable
Description: Clear All button is not working
Steps to Reproduce:
Prerequisites:

  • Login to outbrain.com

Steps to reproduce:

  1. Navigate to: https://my.outbrain.com/amplify/funnel/content
  2. Type something in the "Type in or paste your URL - one or many - here" field.
  3. Click the "Add Content" button.
  4. Click the "Clear All" button.

Expected Behavior:
A popup is displayed. "Are you sure you want to remove the current items?"

Actual Behavior:
Nothing happens.

Notes:

  1. The issue is not reproducible on Chrome Canary or Chrome Release.
  2. Screenshot attached.

Watchers:
@softvision-oana-arbuzov
@softvision-sergiulogigan
@cipriansv

sv;
Screenshot Description

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone Feb 1, 2019
@softvision-sergiulogigan softvision-sergiulogigan changed the title my.outbrain.com - site is not usable my.outbrain.com - Clear All button is not working Feb 1, 2019
@softvision-sergiulogigan softvision-sergiulogigan added the severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. label Feb 1, 2019
@karlcow
Copy link
Member

karlcow commented Feb 4, 2019

<button _ngcontent-c5="" class="filter-options _am_core-clear-all" data-test="_am_core_plinks-list_clear_button">Clear All</button>

The console displays:

15:25:01.072 ERROR TypeError: "this.dialogRef.showModal is not a function"
    showModal dialog.component.ts:167
    showOnInit dialog.component.ts:172
    attachAysnc dialog.service.ts:113
    Angular 7
        invokeTask
        onInvokeTask
        invokeTask
        runTask
        invokeTask
        invoke
        0
    b tracker.js:26
    setTimeout handler*wrapTimer/</< tracker.js:82
    Angular 9
    attachAysnc dialog.service.ts:112
    showConfirm dialog.service.ts:75
    clearCurrentContent plinks-list.component.ts:206
    View_e_1 e.ngfactory.js:109
    Angular 12
    b tracker.js:26
    wrapEventTarget tracker.js:63
    Angular 22
    View_e_0 e.ngfactory.js:212
    Angular 6
tracker.js:formatted:262
    f tracker.js:262
    Angular 4
    RxJS 5
    Angular 11
    b tracker.js:26
    wrapTimer tracker.js:82
    Angular 9
    attachAysnc dialog.service.ts:112
    showConfirm dialog.service.ts:75
    clearCurrentContent plinks-list.component.ts:206
    View_e_1 e.ngfactory.js:109
    Angular 12
    b tracker.js:26
    wrapEventTarget tracker.js:63
    Angular 22
    View_e_0 e.ngfactory.js:212
    Angular 6

webpack:///static/modules/amplify/dialog/dialog.component.ts

  showModal() {
    this.removed = false
    this.dialogRef.showModal()
  }

private dialogRef: DialogType and import { DialogType } from './dialog.model'

I don't see a dialog.model

Screenshot Description

@wisniewskit do you have an idea?

@wisniewskit
Copy link
Member

In this case, it's because they're using a element, which has its own showModal method in the HTML standard. But Firefox doesn't yet support elements (you can enable experimental support in about:config, and then the dialogs work).

Now I do see references to window.dialogPolyfill in the same script the exception appears in, but it doesn't seem as though OutBrain actually load that polyfill. So this seems like site error to me.

@wisniewskit wisniewskit self-assigned this Feb 5, 2019
@wisniewskit wisniewskit added the type-html Generic HTML issues label Feb 5, 2019
@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@karlcow
Copy link
Member

karlcow commented Oct 15, 2019

The UI has totally changed. And the problem seems to have vanished.
Or we need better step by step to reproduce. :)

@softvision-sergiulogigan
Copy link
Author

The UI has totally changed. And the problem seems to have vanished.

I agree.

Or we need better step by step to reproduce. :)

Tried lots of buttons, all seem to work now.

@lock
Copy link

lock bot commented Oct 24, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue at https://webcompat.com/issues/new if you are experiencing a similar problem.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-important severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. type-html Generic HTML issues
Projects
None yet
Development

No branches or pull requests

5 participants