www.xnxx.com - The Bookmark button does not trigger the Bookmark prompt

[softvision-sergiulogigan]

URL: https://www.xnxx.com/

Browser / Version: Firefox Nightly 67.0a1 (2019-03-06)
Operating System: Windows 10
Tested Another Browser: Yes

Problem type: Site is not usable
Description: The Bookmark button does not trigger the Bookmark prompt
Steps to Reproduce:

1. Navigate to: https://www.xnxx.com/
2. Click on the "Bookmark" button, in th top-right side of the page.

Expected Behavior:
A bookmark prompt is displayed.

Actual Behavior:
Nothing happens.

Notes:

1. The issue is not reproducible on Chrome.

Watchers:
@softvision-oana-arbuzov
@softvision-sergiulogigan
@cipriansv

sv;

Browser Configuration

• None

From webcompat.com with ❤️

[softvision-sergiulogigan]

[karlcow]

<a href="#" class="bookmark-link icon-sitenav-bg mobile-hide" target="_self" title="XNXX VIDEOS" rel="sidebar">
  <span class="icon bookmark"></span>
</a>

and this interesting… script.

  define("lib/helpers/bookmark", [], function() {
    return function(e, t, i) {
      (e = $(e)),
        e.data("bookmark-title") && (i = e.data("bookmark-title")),
        e.on("click", function(n) {
          if (window.sidebar && window.sidebar.addPanel)
            window.sidebar.addPanel(t, i, "");
          else if (window.external && "AddFavorite" in window.external)
            window.external.AddFavorite(t, i);
          else {
            if (
              (window.opera && window.print) ||
              (window.sidebar && !(window.sidebar instanceof Node))
            )
              return e.attr("rel", "sidebar").attr("title", i), !0;
            alert(
              "Press " +
                (-1 !== navigator.userAgent.toLowerCase().indexOf("mac")
                  ? "Command/Cmd"
                  : "CTRL") +
                " + D to bookmark this page."
            );
          }
          return n.preventDefault(), !1;
        });
    };
  }),

Basically this is a long list of sniffing attempts.
on macOS Chrome Canary it displays an… alert, just because of "mac" in the ua string.

Moving to needscontact.

[miketaylr]

              return e.attr("rel", "sidebar").attr("title", i), !0;

We end up in this condition, and support for that stopped working in Firefox in 2018: https://www.fxsitecompat.dev/en-CA/docs/2018/sidebar-link-type-is-no-longer-supported/

[miketaylr]

Attempting contact via https://info.xnxx.com/contact -- the fix would be to just treat us the same way as Chrome (show the alert).

[softvision-oana-arbuzov]

The issue has been fixed. A popup with info on how to bookmark the page is displayed (Ctrl+D), which activates the "Bookmarks" menu.

Tested with:
Browser / Version: Firefox Nightly 102.0a1 (2022-05-04)
Operating System: Windows 10 Pro

[inv_18/2022]