Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.geeksforgeeks.org - "Login" popup keeps being dismissed #28446

Closed
Akhi1 opened this issue Mar 27, 2019 · 8 comments
Closed

www.geeksforgeeks.org - "Login" popup keeps being dismissed #28446

Akhi1 opened this issue Mar 27, 2019 · 8 comments
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-important severity-critical The site or core functionality is unusable, or you would probably open another browser to use it.
Milestone

Comments

@Akhi1
Copy link

Akhi1 commented Mar 27, 2019

URL: https://www.geeksforgeeks.org/loops-in-javascript/

Browser / Version: Firefox Mobile 67.0
Operating System: Android 6.0.1
Tested Another Browser: No

Problem type: Design is broken
Description: Issue with login popup in mobile
Steps to Reproduce:
login popup not staying until I type in my password. It just closed after typing email id. Cannot login. My mobile is a 5.2' screen.

Browser Configuration
  • mixed active content blocked: true
  • image.mem.shared: true
  • buildID: 20190322012752
  • tracking content blocked: false
  • gfx.webrender.blob-images: true
  • hasTouchScreen: true
  • mixed passive content blocked: false
  • gfx.webrender.enabled: false
  • gfx.webrender.all: false
  • channel: beta

Console Messages:

[u'[JavaScript Warning: "unreachable code after return statement" {file: "https://www.geeksforgeeks.org/wp-content/themes/iconic-one/js/gfg.min.js?ver=10.24" line: 93 column: 2387 source: "uiz_finished[N]&&!triggered){return mtq_exit_warning_string;triggered=!0}}};function mtq_scroll_anchor(mtqid){if(mtq_vie"}]', u'[JavaScript Warning: "This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!" {file: "https://www.geeksforgeeks.org/loops-in-javascript/" line: 0}]', u'[JavaScript Error: "uncaught exception: TagError: adsbygoogle.push() error: No slot size for availableWidth=0"]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Directive child-src has been deprecated. Please use directive worker-src to control workers, or directive frame-src to control frames respectively."]', u'[JavaScript Warning: "Content Security Policy: Directive child-src has been deprecated. Please use directive worker-src to control workers, or directive frame-src to control frames respectively."]', u'[JavaScript Warning: "Content Security Policy: Directive child-src has been deprecated. Please use directive worker-src to control workers, or directive frame-src to control frames respectively."]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Loading failed for the <script> with source https://srv.buysellads.com/ads/get/ids/CVSIE53W/?r=1553653800000." {file: "https://www.geeksforgeeks.org/loops-in-javascript/" line: 1}]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring \'unsafe-inline\' within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring https: within script-src: strict-dynamic specified"]', u'[JavaScript Warning: "Content Security Policy: Ignoring http: within script-src: strict-dynamic specified"]', u'[JavaScript Error: "Error: Load timeout for modules: typeahead,bloodhound\nhttp://requirejs.org/docs/errors.html#timeout" {file: "https://cdnjs.cloudflare.com/ajax/libs/require.js/2.1.14/require.min.js" line: 8}]\nC@https://cdnjs.cloudflare.com/ajax/libs/require.js/2.1.14/require.min.js:8:252\nD@https://cdnjs.cloudflare.com/ajax/libs/require.js/2.1.14/require.min.js:13:454\nD/X<@https://cdnjs.cloudflare.com/ajax/libs/require.js/2.1.14/require.min.js:14:126\n', u'[JavaScript Error: "Blocked loading mixed active content http://freegeoip.net/shutdown" {file: "https://www.geeksforgeeks.org/loops-in-javascript/" line: 0}]', u'[JavaScript Warning: "<script> source URI is not allowed in this document: https://freegeoip.net/json/?callback=callback1553655165573." {file: "https://www.geeksforgeeks.org/loops-in-javascript/" line: 1}]', u'[JavaScript Warning: "unreachable code after return statement" {file: "https://www.geeksforgeeks.org/wp-content/themes/iconic-one/js/gfg.min.js?ver=10.24" line: 93 column: 2387 source: "uiz_finished[N]&&!triggered){return mtq_exit_warning_string;triggered=!0}}}"}]']

Reported by @Akhi1

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone Mar 27, 2019
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title www.geeksforgeeks.org - design is broken www.geeksforgeeks.org - "Login" popup keeps being dismissed Apr 1, 2019
@softvision-oana-arbuzov softvision-oana-arbuzov added the severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. label Apr 1, 2019
@softvision-oana-arbuzov
Copy link
Member

Thanks for the report @Akhi1 , I was able to reproduce the issue.
LoginPopupDismisses

Note: Not reproducible on Chrome.

Tested with:
Browser / Version: Firefox Nightly 68.0a1 (2019-03-31)
Operating System: LG G5 (Android 7.0) - 1440 x 2560 pixels (~554 ppi pixel density), Samsung Galaxy S7 Edge (Android 8.0.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)

Moving to Needsdiagnosis for further investigation.

@karlcow karlcow self-assigned this Apr 1, 2019
@karlcow
Copy link
Member

karlcow commented Apr 1, 2019

when I first access the site I get this.

Screenshot Description

it takes around 5-10s to appear on both chrome and firefox.

Let me close this pop up and then hit the login link. When I do that the same window reopens on both firefox and chrome.

Let's hit the email field.

  • no issue on rdm
  • it disappears on the device.

This is probably due to the virtual keyboard creating either a resize event(?) or changing the size of the window. On Chrome. the keyboard comes on top of everything.

@karlcow
Copy link
Member

karlcow commented Apr 2, 2019

The modal window is managed by https://util.geeksforgeeks.org/js/loginModal-1.0.js?ver=1.8

It reminds me of https://bugzilla.mozilla.org/show_bug.cgi?id=1139747

As soon as we exit this function

    document.addEventListener('blur', function (i) {
      var n = t(i.target);
      if (n.is(e)) {
        var s = '.prefix';
        0 === n[0].value.length && !0 !== n[0].validity.badInput && null === n.attr('placeholder') && (s += ', label'),
        n.siblings(s).removeClass('active'),
        M.validate_field(n)
      }
    }, !0);

the keyboard appears and disappears.

@karlcow
Copy link
Member

karlcow commented Apr 2, 2019

Sorry the keyboard appears and the modal window disappears..

@karlcow
Copy link
Member

karlcow commented Apr 2, 2019

Oh and there is this too.
https://bugzilla.mozilla.org/show_bug.cgi?id=1170968

I wonder if chrome behaves differently when virtual keyboard is activated.
Maybe we should open an issue on bugzilla.mozilla.org

@wisniewskit
Copy link
Member

wisniewskit commented Apr 4, 2019

If I tell Tinker Tester Developer Spy to ignore resize events, then the problem does seem to go away. Also, the problem doesn't reproduce on Fenix or the Reference Browser, so this is almost certainly a dupe of bz1007286.

Given that, the site could likely also work around this issue in Fennec if desired, by using the orientationchange events instead of resize as seen in this similar issue.

@karlcow karlcow removed their assignment Apr 30, 2019
@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@softvision-oana-arbuzov
Copy link
Member

The issue is still reproducible on my side.

Tested with:
Browser / Version: Firefox Nightly 68.3a1 (2019-11-12), Firefox Preview Nightly 191112 (🦎: 72.0a1-20191105095755)
Operating System: Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density), Samsung Galaxy S7 Edge (Android 8.0.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)

@softvision-raul-bucata
Copy link

The issue is no longer reproducible:

Screenshot_21

Tested with:
Browser / Version: Firefox Nightly 91.0a1 (2015820939 -🦎91.0a1-20210708091856🦎)
Operating System: Samsung A51 (Android 11) -1080 × 2400 pixels 20:9 aspect ratio (~405 ppi density)

Closing this as FIXED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-important severity-critical The site or core functionality is unusable, or you would probably open another browser to use it.
Projects
None yet
Development

No branches or pull requests

7 participants