Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qiye.163.com - see bug description #2950

Closed
MDTsai opened this issue Aug 5, 2016 · 10 comments
Closed

qiye.163.com - see bug description #2950

MDTsai opened this issue Aug 5, 2016 · 10 comments
Milestone

Comments

@MDTsai
Copy link

MDTsai commented Aug 5, 2016

URL: http://qiye.163.com/
Browser / Version: Firefox 49.0
Operating System: Mac OS X 10.11
Problem type: Something else - I'll add details below

Steps to Reproduce

  1. Navigate to: http://qiye.163.com/
  2. scroll down to "buy users" area

Expected Behavior:
Should be one line

Actual Behavior:
Last character is in next line

Works fine in Chrome 51 and Safari 9.1.2

Screenshot Description

From webcompat.com with ❤️

@karlcow
Copy link
Member

karlcow commented Aug 8, 2016

Thanks @MDTsai

The user-agent stylesheet for the input element

  • in Safari (WebKit) border-width: 2px and display: inline-block
  • in Opera (Blink) border-width: 2px and display: inline-block
  • in Firefox (Gecko) border-width: 3px and display: inline

Testing with a simple html page with only an input element.

  • Left: WebKit/Blink
  • Right: Gecko

capture d ecran 2016-08-08 a 09 44 49

Once we set the default value to 2px it fixes the issue.

Two possible actions:

  1. Convince them to add rule for input element so that it is fixed at 2px.
  2. Change the Gecko user-agent stylesheet. (I did it in the past I can do it again)

Switching to needscontact, but will probably close as duplicate of a bugzilla bug if we decide to go with option 2. I'll prepare a patch if yes.

At least according to the default CSS in CSS2, we are wrong for the value of the input for display

input, select { display: inline-block }

Now the funny game is that, how many sites do we break if we change the default value that some people might have compensated for. 📎

@miketaylr @denschub @adamopenweb @MDTsai opinions?

@miketaylr
Copy link
Member

Convince them to add rule for input element so that it is fixed at 2px.

This seems like the safest option, in that it won't unintentionally break/regress other sites' layout.

If someone wanted to do some kind of analysis to see if a local build with this new border-width broke top sites, that would be interesting.

@karlcow
Copy link
Member

karlcow commented Aug 17, 2016

@MDTsai the ball is in your camp. If you could find a contact and all them to add the rule.
Thanks.

@MDTsai
Copy link
Author

MDTsai commented Aug 17, 2016

OK, try to reach them today!

@karlcow
Copy link
Member

karlcow commented Sep 13, 2016

@MDTsai did you get any contacts?

The company behind 163 is NetEase
https://en.wikipedia.org/wiki/NetEase

And Probably people contributing to @NetEase could help us find the right person for fixing this front-end issue.

@bingohuang Maybe can help us.

@MDTsai
Copy link
Author

MDTsai commented Sep 13, 2016

@karlcow Customer service of 163.com said they can't reproduce on their side, so they can't help on this.

@karlcow
Copy link
Member

karlcow commented Sep 13, 2016

hehe. I wonder what they tested. It's reproducible perfectly.

@MDTsai
Copy link
Author

MDTsai commented Dec 20, 2016

Ping @andrewleo and @lucyking if they can share some connection to 163.com

@lucyking
Copy link

Many thanks for the reporting && exhaustive analysis. I have left NetEase already,but I will try to convey this bug to the Email Department.

@karlcow karlcow added this to the sitewait milestone Oct 30, 2017
@reinhart1010
Copy link

It seems that this issue is fixed.
image

@reinhart1010 reinhart1010 modified the milestones: sitewait, fixed Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants