Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Futureshop Canada blank page #300

Closed
kbrosnan opened this issue Sep 4, 2014 · 9 comments
Closed

Mobile Futureshop Canada blank page #300

kbrosnan opened this issue Sep 4, 2014 · 9 comments

Comments

@kbrosnan
Copy link

kbrosnan commented Sep 4, 2014

URL: http://m.futureshop.ca
Browser / Version: Firefox 34.0
Operating System: Android
Problem type: Looks like the website has a bug.
Site owner: No

Steps to Reproduce

  1. Navigate to: http://m.futureshop.ca
  2. No content is shown

Expected Behavior: Content appears and the user is able to interact with the site
Actual Behavior: A blank white page is displayed

@Rudloff
Copy link

Rudloff commented Sep 4, 2014

Same thing with Firefox 32 on Linux and with Firefox OS.

@hallvors
Copy link

hallvors commented Sep 5, 2014

bootstrap.css styles body with display:none :

body{
-webkit-touch-callout:none;
-webkit-text-size-adjust:none;
-webkit-tap-highlight-color:rgba(0,0,0,0);
display:none;
font-size:12px;
opacity:none
}

I suppose some JS supposed to undo that is failing.

In script.min.js, method onAppStart():

$("body").show();

The show() call fails because this code:

      if (a.style) {
        b = a.style.display;
        if (!c._data(a, 'olddisplay') && b === 'none') b = a.style.display = '';
        b === '' && c.css(a, 'display') === 'none' && c._data(a, 'olddisplay', za(a.nodeName))
      }
    }
    for (d = 0; d < e; d++) {
      a = this[d];
      if (a.style) {
        b = a.style.display;
        if (b === '' || b === 'none') a.style.display = c._data(a, 'olddisplay') || ''
      }
    }

more precisely the za(a.nodeName) call, tries to read the "default" style for an element by adding an IFRAME to the document, appending an element inside it and calling into jQuery's css() method. For some reason this seems to return 'undefined' for the BODY element's display property in Firefox. Looks like a bug in Firefox's layout / CSSOM code, compare http://jsfiddle.net/zn7akfxg/ in Gecko and WebKit-based browsers.

@hallvors
Copy link

hallvors commented Sep 5, 2014

https://bugzilla.mozilla.org/show_bug.cgi?id=548397 gotcha. Not an issue for outreach, so I'll close this webcompat.com bug.

@Rudloff
Copy link

Rudloff commented Sep 5, 2014

I think this raises another issue: Their website can't be used at all with JavaScript disabled.

@hallvors
Copy link

hallvors commented Sep 5, 2014

Absolutely. Not exactly best practise and non-obtrusive enhancements over there.. :-/

@adamopenweb
Copy link
Collaborator

Just to add, there is an open bug for Firefox OS and Futureshope/Bestbuy. https://bugzilla.mozilla.org/show_bug.cgi?id=974529. First contact attempt wasn't successful if anyone knows someone there.

@miketaylr
Copy link
Member

I'm not so sure that this is https://bugzilla.mozilla.org/show_bug.cgi?id=548397. This was a bug that was fixed in jQuery 1.8.3. See #663 (comment) for more info.

@karlcow
Copy link
Member

karlcow commented Mar 4, 2015

Future Shop stores operate as a division of Burnaby-based Best Buy Canada Ltd., a wholly-owned subsidiary of Best Buy Co., Inc. (NYSE:BBY).

so we need to find best buy I guess.
There is @bestbuycom but the last update is one year old with @agent462
There is @BestBuyAPIs more encouraging with the latest updates (hours away) by @cmlizama and @jkap

That could help for finding the right persons for all these bugs:

@karlcow
Copy link
Member

karlcow commented May 7, 2015

I wonder if @fernando-fanfair or @albrec or @bestbuycom or @agent462 or @anpainte
can help us contact the right person at BestBuy for solving the issue.

As explained in #663

"The suggested fix would be to update to jQuery >= 1.8.3, OR to change $("body").show(); to $("body").css("display", "block");"

@karlcow karlcow added this to the wontfix milestone Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants
@miketaylr @hallvors @kbrosnan @karlcow @Rudloff @adamopenweb and others