Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghacks.net - desktop site instead of mobile site #3142

Closed
webcompat-bot opened this issue Sep 5, 2016 · 8 comments
Closed

ghacks.net - desktop site instead of mobile site #3142

webcompat-bot opened this issue Sep 5, 2016 · 8 comments
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Milestone

Comments

@webcompat-bot
Copy link

URL: ghacks.net
Browser / Version: Firefox Mobile 48.0
Operating System: Android 4.4.2
Problem type: Desktop site instead of mobile site

Steps to Reproduce

  1. Navigate to: ghacks.net

Expected Behavior: mobile site is served

Actual Behavior: mobile site is served on Chrome but on Firefox for Android, desktop site is served.

From webcompat.com with ❤️

@karlcow
Copy link
Member

karlcow commented Sep 6, 2016

seeAlso: #870

On Firefox

Screenshot of the site issue

On Chrome

Screenshot of the site issue

And… https://b.marfeel.com/statics/www.ghacks.net/index/main.s.js?build=11810

Marfeel is a framework which has been contacted in the past. The Marfeel team has not yet delivered a compatible version of their framework. We suggested in the past what needs to be fixed. fwiw the site is working on Gecko with our -webkit- implementation, but it requires user-agent override.

SeeAlso: https://bugzilla.mozilla.org/show_bug.cgi?id=1149160

@karlcow
Copy link
Member

karlcow commented Sep 13, 2016

Note that @Marfeel is on GitHub, but not really active.

I wonder if we could restart the discussion started a while ago @xbeumala

@karlcow
Copy link
Member

karlcow commented Sep 13, 2016

Marfeel CTO is on Github @oliverfernandez but I doubt he is reading his tweets.

@xbeumala
Copy link

Hi, both @oliverfernandez and me are listening to this conversation. At this point this is a matter of prioritization of the tasks. Supporting Firefox has an important impact on testing and apply changes to historical webkit only features that we've been using. I'm pretty sure we'll into this, we'll let you know ASAP as it's fixed

@karlcow
Copy link
Member

karlcow commented Sep 15, 2016

We are still interested to hear what are the features which are really unique to webkit.

For example, this is ghacks.net on Firefox 51 when we cheat about -webkit-.

screen shot 2016-09-15 at 14 40 07

@karlcow
Copy link
Member

karlcow commented Sep 15, 2016

The only remaining thing according to @oliverfernandez in Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1149160 was the -webkit- prefixes to switch to Web standards (and the UA sniffing which is done by marfeel framework).

@karlcow karlcow added this to the sitewait milestone Oct 30, 2017
@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@cipriansv cipriansv added the severity-important A non-core broken piece of functionality, not behaving the way you would expect. label Aug 21, 2019
@cipriansv
Copy link

I retested the issue and it is still reproducible on my side.

image

Tested with:
Browser / Version: Firefox Nightly 68.1a1 (2019-08-20), Firefox Preview 1.3.0 (Build #12321503)
Operating System: Huawei P10 (Android 8.0) - 1080 x 1920 pixels (~432 ppi pixel density)

@softvision-oana-arbuzov
Copy link
Member

The layout has changed and the issue no longer occurs. I get the same mobile layout as in Chrome.
image

Tested with:
Browser / Version: Firefox Nightly 90.0a1 (🦎 90.0a1-20210510093555)
Operating System: Google Pixel 5 (Android 11) - 1080 x 2340 pixels, 19.5:9 ratio (~432 ppi density)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Projects
None yet
Development

No branches or pull requests

6 participants