Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc.rust-lang.org - "Settings" icon overlaps "Search" field #47440

Closed
softvision-oana-arbuzov opened this issue Dec 30, 2019 · 3 comments
Closed
Labels
browser-fenix browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine form-v2-experiment priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-css-flexbox
Milestone

Comments

@softvision-oana-arbuzov
Copy link
Member

softvision-oana-arbuzov commented Dec 30, 2019

URL: https://doc.rust-lang.org/std/cmp/macro.PartialOrd.html

Browser / Version: Firefox Preview Nightly 191230 (🦎: 73.0a1-20191227094418), Firefox Nightly 68.4a1 (2019-12-26)
Operating System: Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density), Samsung Galaxy S7 Edge (Android 8.0.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)
Tested Another Browser: Yes Chrome

Problem type: Design is broken
Description: Items are overlapped

Steps to reproduce:

  1. Navigate to https://doc.rust-lang.org/std/cmp/macro.PartialOrd.html
  2. Observe the "Search" field.

Expected behavior:
No elements are overlapped. "Search" field is displayed on the left side of "Settings" icon.

Actual behavior:
"Settings" icon overlaps "Search" field.

Notes:

  1. The issue is not reproducible on Chrome.
  2. Screenshot attached.
  3. Also reproducible on RDM.

Affected area:

<div class="search-container">
	<div>
		<select id="crate-search">
			<option value="All crates">All crates</option>
			<option value="alloc">alloc</option>
			<option value="core">core</option>
			<option value="proc_macro">proc_macro</option>
			<option value="std">std</option>
			<option value="test">test</option>
		</select>
		<input class="search-input" name="search" autocomplete="off" spellcheck="false" placeholder="Click or press ‘S’ to search, ‘?’ for more options…" type="search">
	</div>
	<a id="settings-menu" href="../../settings.html">
		<img src="../../wheel1.40.0.svg" alt="Change settings" width="18">
	</a>
</div>

Watchers:
@softvision-oana-arbuzov
@softvision-sergiulogigan
@cipriansv

sv;

Screenshot Description

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone Dec 30, 2019
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine form-v2-experiment labels Dec 30, 2019
@softvision-oana-arbuzov softvision-oana-arbuzov added browser-fenix browser-firefox-mobile priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. and removed browser-firefox labels Dec 30, 2019
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title doc.rust-lang.org - design is broken doc.rust-lang.org - "Settings" icon overlaps "Search" field Dec 30, 2019
@ksy36
Copy link
Contributor

ksy36 commented Dec 30, 2019

Adding min-width: 0; to the input style fixes the issue:

#crate-search + .search-input {
    border-radius: 0 1px 1px 0;
    width: calc(100% - 32px);
    min-width: 0; 
}

So I think this makes a case for https://bugzilla.mozilla.org/show_bug.cgi?id=1136312

@ksy36
Copy link
Contributor

ksy36 commented Dec 30, 2019

Actually there is a bug for inputs with percent sizes and "compressible" min-content: https://bugzilla.mozilla.org/show_bug.cgi?id=1585485

@lock
Copy link

lock bot commented Jan 6, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue at https://webcompat.com/issues/new if you are experiencing a similar problem.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser-fenix browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine form-v2-experiment priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-css-flexbox
Projects
None yet
Development

No branches or pull requests

3 participants